[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Minios-devel] [UNIKRAFT PATCHv5 5/6] plat/common: Add a platform API to get IRQ from device tree
Hi Sharan On 2019/7/10 17:53, Sharan Santhanam wrote: Hello, Please find the comment inline. Thanks & Regards Sharan On 6/28/19 9:09 AM, Jia He wrote:plat/common - Does not seem the right place for this header file. I had made a comment previously to put header there but with the current structures of the platform library I feel it is better to move it into the gic driver or the ofw. I prefer to have it within the ofw driver. If you agree we could move both the implementation and the header files into the ofw driver.From: Jianyong Wu <jianyong.wu@xxxxxxx> When we get irq number from device tree, it contains more than one items, like irq type, hardware irq number. This function will help us to translate these items into one unique platform irq number. Signed-off-by: Wei Chen <wei.chen@xxxxxxx> Signed-off-by: Jianyong Wu <jianyong.wu@xxxxxxx> Signed-off-by: Jia He <justin.he@xxxxxxx> --- plat/common/include/gic_fdt.h | 48 ++++++++++++++++++++++++++++++++++ plat/drivers/gic/gic-v2.c | 49 +++++++++++++++++++++++++++++++++--What do you think about it? Sorry for my partially missing your comments ;-) I had moved the gic_fdt.h to ofw directory in v6. But when comes to implemention file, do you wanna move the gic-v2.c to ofw? Or merely this patch 5/6 changing? Thanks for the clarification --- Cheers, Justin (Jia He) _______________________________________________ Minios-devel mailing list Minios-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/minios-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |