Re: [Minios-devel] [UNIKRAFT/LIBNEWLIB PATCH] Expose getline

[Costin Lupu <costin.lup@xxxxxxxxx>]

Forgot to add:

Reviewed-by: Costin Lupu <costin.lupu@xxxxxxxxx>

On 7/30/19 5:42 PM, Costin Lupu wrote:
> Hi Felipe,
> 
> Please see one minor comment inline. I think it can be fixed when
> pushing upstream.
> 
> On 7/30/19 5:45 PM, Felipe Huici wrote:
>> Signed-off-by: Felipe Huici <felipe.huici@xxxxxxxxx>
>> ---
>>  include/stdio.h | 43 +++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 43 insertions(+)
>>  create mode 100644 include/stdio.h
>>
>> diff --git a/include/stdio.h b/include/stdio.h
>> new file mode 100644
>> index 0000000..3c2f86d
>> --- /dev/null
>> +++ b/include/stdio.h
>> @@ -0,0 +1,43 @@
>> +/* SPDX-License-Identifier: BSD-3-Clause */
>> +/*
>> + * libnewlib glue code
>> + *
>> + * Authors: Felipe Huici <felipe.huici@xxxxxxxxx>
>> + *
>> + * Copyright (c) 2019, NEC Europe Ltd., NEC Corporation. All rights 
>> reserved.
>> + *
>> + * Redistribution and use in source and binary forms, with or without
>> + * modification, are permitted provided that the following conditions
>> + * are met:
>> + *
>> + * 1. Redistributions of source code must retain the above copyright
>> + *    notice, this list of conditions and the following disclaimer.
>> + * 2. Redistributions in binary form must reproduce the above copyright
>> + *    notice, this list of conditions and the following disclaimer in the
>> + *    documentation and/or other materials provided with the distribution.
>> + * 3. Neither the name of the copyright holder nor the names of its
>> + *    contributors may be used to endorse or promote products derived from
>> + *    this software without specific prior written permission.
>> + *
>> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
>> IS"
>> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
>> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
>> PURPOSE
>> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
>> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
>> THE
>> + * POSSIBILITY OF SUCH DAMAGE.
>> + *
>> + * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
>> + */
>> +#ifndef LIBLWIP_STDIO_H
>> +#define LIBLWIP_STDIO_H
>> +
> 
> s/LIBLWIP_STDIO_H/LIBNEWLIB_STDIO_H
> 
>> +#define getline  __getline
>> +
>> +#include_next <stdio.h>
>> +
>> +#endif
>>

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel