[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Minios-devel] [UNIKRAFT PATCH] build: Define preprocessing symbol for library name
- To: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>, minios-devel@xxxxxxxxxxxxx
- From: Costin Lupu <costin.lupu@xxxxxxxxx>
- Date: Mon, 5 Aug 2019 17:03:27 +0200
- Cc: felipe.huici@xxxxxxxxx, sharan.santhanam@xxxxxxxxx
- Delivery-date: Mon, 05 Aug 2019 15:03:38 +0000
- Ironport-phdr: 9a23:Z+k4DB3GOPHobImWsmDT+DRfVm0co7zxezQtwd8ZsesWKfzxwZ3uMQTl6Ol3ixeRBMOHsqgC0rKJ+PC5EUU7or+5+EgYd5JNUxJXwe43pCcHRPC/NEvgMfTxZDY7FskRHHVs/nW8LFQHUJ2mPw6arXK99yMdFQviPgRpOOv1BpTSj8Oq3Oyu5pHfeQpFiCejbb9oMRm6sQfcusYVjId/N6081gbHrnxUdupM2GhmP0iTnxHy5sex+J5s7SFdsO8/+sBDTKv3Yb02QaRXAzo6PW814tbrtQTYQguU+nQcSGQWnQFWDAXD8Rr3Q43+sir+tup6xSmaIcj7Rq06VDi+86tmTgLjhTwZPDAl7m7Yls1wjLpaoB2/oRx/35XUa5yROPZnY6/RYc8WSW9HU81MVSJOH5m8YpMSAeQfM+ZWr4rzqVUAohSxBwajGOzhxyRUhn/vx6A2z/gtHA/E0QEmAtkAsG7UrNLwNKoKT+21y7LIzSnCb/NQxDzz7pXIcgg8ofqRWr9/bc3RyVIzFwPEiFWcs4jlPy6N1uQQqGWU8/FgWfi3i246sA59uCKvxsA1h4TPm4kbyUjE+D1kzIs6ONG0Uk12bN6+HJdOqS2XNZF6T806T2xstis20LILtYKhcCQXzJkr2wTTZviIfoWO/xntTvyeIS1ii3JgYL+/ghGy/lW+xeDkTcm01UpKrjJCktnRqnABzxzT5daDSvt65kqhxzOP2BrS6uFAO0w7ibHbJ4Q5wr4tjZUfq17DHijulEX3iq+ZaFkk9/C15+nof7nqvJyROo9uhg3gLKgjmNazDOogPggLRWeb+OC81LP5/U3+RbVHluE5kq7CsJDGJMQboLS1AwtI0oY79hayFCup0M8CkXkfMVJKYwiLj5LuO13WOvD3Ee+/g0iwkDds3/3GO7zhApPMLnjEi7ftZKty5FBCyAUtydBS/JZUCrAaIPLvQU/9rtPZAQE/MwCuxObnEtp93JsEWW2TGq+ZLL/SsViQ6+IhPeaMYI4VuC7jJPQ/5/7ukH45lkMcfaSy25sYdmy3HvB8LEqCe3bjnMoBG38QvgUiVOzqlEGCUTlLanapX6Iz/Cs7B5igDYvZXYCimrqB3Du7HpJMYGBJEFWMHGzud4qaR/gMbDidLdR7njMaSLirU5Uh2g22tA/m17pnKfLZ+jYZtZLm09h14ffflRIv9TNqCcSc0n+CT3tvk2MOWTA5wKR/rlZmxVuZz6d4nq8QKdsG3PJMVQFyFoPRyf53EZimQQPEedHPS0urRMerGxk3Q9k1ytVIblsrX52njxbC2DHvD7ILmrijAJ0v7rmaz3X3YcFnxCXozq4k2nIhWddOMyWCm7Ziv1zYAJXVkkPfk7uyaIwXx2jV6W3F123Y7xIQaxJ5TaiQBSNXXUDRt9msoxqaF7I=
- Ironport-sdr: yDkBAL/Ae5FghHeQKQa5EcccyTBUO+6vpffCXQa1j8+jVLDYt84nNnEZy1jK8BhZbZ9KtPFvWR b0P9B+/SbF4g==
- List-id: Mini-os development list <minios-devel.lists.xenproject.org>
On 8/5/19 2:27 PM, Simon Kuenzer wrote:
> Hey Costin,
>
> my two cents to this patch: I remember a similar case that we had in
> lib/ukdebug: A header is exposing different definitions depending if it
> is included from within the library or externally. For this purpose, we
> add the define as library-local flag within its Makefile.uk instead:
>
> LIBUKDEBUG_CFLAGS-y += -D__IN_LIBUKDEBUG__
>
> Each library that needs something similar could solve the issue the same
> way (like lwip). The building blocks are already there.
> I think this is a more conservative and maybe also safer approach. Less
> flags are set automatically by the build system which may prevent us
> from conflicts at later points.
Alright, I will use the same approach for lwip then.
Costin
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel
|
