[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH 2/5] build: Introduce UK_DEBUG_IMAGES, UK_DEBUG_IMAGES-y



Hello Simon,

This patch seems fine.

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

Thanks & Regards
Sharan

On 7/22/19 2:31 PM, Simon Kuenzer wrote:
UK_DEBUG_IMAGES, UK_DEBUG_IMAGES-y are introduced in order to enable
for each platform to specify which images contain debugging
information and for which ones gdb helper scripts should be generated.

Note, this patch temporarily disables the generation of those helper
scripts because none of the platforms populates the image names. The
follow-up patches are adopting the platform linker files in order to
re-introduce this functionality.

Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
---
  Makefile | 9 ++++++---
  1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index 6de41605..f728081e 100644
--- a/Makefile
+++ b/Makefile
@@ -532,9 +532,9 @@ objs: $(UK_OBJS) $(UK_OBJS-y)
libs: $(UK_ALIBS) $(UK_ALIBS-y) $(UK_OLIBS) $(UK_OLIBS-y) -images: $(UK_IMAGES) $(UK_IMAGES-y)
+images: $(UK_DEBUG_IMAGES) $(UK_DEBUG_IMAGES-y) $(UK_IMAGES) $(UK_IMAGES-y)
-GDB_HELPER_LINKS := $(addsuffix .dbg-gdb.py,$(UK_IMAGES-y) $(UK_IMAGES))
+GDB_HELPER_LINKS := $(addsuffix .gdb.py,$(UK_DEBUG_IMAGES) 
$(UK_DEBUG_IMAGES-y))
  $(GDB_HELPER_LINKS):
        $(call verbose_cmd,LN,$(notdir $@), ln -sf uk-gdb.py $@)
@@ -560,7 +560,10 @@ clean-libs: $(addprefix clean-,\
  clean: clean-libs
        $(call verbose_cmd,CLEAN,build/,$(RM) \
                $(UK_CONFIG_OUT) \
-               $(call build_clean,$(UK_IMAGES-y)) \
+               $(call build_clean,\
+                       $(UK_DEBUG_IMAGES) $(UK_DEBUG_IMAGES-y) \
+                       $(UK_IMAGES) $(UK_IMAGES-y)) \
+               $(GDB_HELPER_LINKS) $(BUILD_DIR)/uk-gdb.py \
                $(UK_CLEAN) $(UK_CLEAN-y))
else # !($(UK_HAVE_DOT_CONFIG),y)


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.