[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH 0/3] Spit ofw, gic-v2 to independent library



Hello Justin,

Thank you for the patch series.

I would like to suggest one more change in the order of the patches. Since the gic-v2 driver

depends on the fdt, it might be wise to split it out first making it dependent on the PLAT_KVM and

then split ofw series and explicitly add a dependency from the gic driver to the ofw driver. In my opinion

this make the split more explicit.

Thanks & Regards

Sharan

On 7/29/19 1:26 PM, Jia He wrote:
This patch set try to Spit ofw,gic-v2 to independent library, just like
what we did for virtio and pci.

Jia He (3):
   build: Split ofw from kvm plat to independent library
   build: Split gic-v2 from kvm plat to independent library
   plat/drivers/ofw: Move gic_get_irq_from_dtb to gic_fdt.c

  plat/drivers/ofw/fdt.c     | 21 --------------
  plat/drivers/ofw/gic_fdt.c | 56 ++++++++++++++++++++++++++++++++++++++
  plat/kvm/Config.uk         | 13 +++++++++
  plat/kvm/Makefile.uk       | 30 ++++++++++++++++++--
  4 files changed, 97 insertions(+), 23 deletions(-)
  create mode 100644 plat/drivers/ofw/gic_fdt.c


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.