Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH 1/8] Makefile.uk: Remove useless include directives

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Patch looks good, thanks.

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 05.08.19, 17:18, "Costin Lupu" <costin.lupu@xxxxxxxxx> wrote:

    The removed lines from Makefile.uk do not have any kind of effect because
    $(LIBNEWLIBGLUE) is not a configuration flag.
    
    Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
    ---
     Makefile.uk | 5 -----
     1 file changed, 5 deletions(-)
    
    diff --git a/Makefile.uk b/Makefile.uk
    index 9d1b275..abd556a 100644
    --- a/Makefile.uk
    +++ b/Makefile.uk
    @@ -70,11 +70,6 @@ CINCLUDES-$(CONFIG_LIBNEWLIBC)   += 
-I$(LIBNEWLIB_LIBC)/include
     CXXINCLUDES-$(CONFIG_LIBNEWLIBC) += -I$(LIBNEWLIBC_BASE)/include
     CXXINCLUDES-$(CONFIG_LIBNEWLIBC) += -I$(LIBNEWLIB_LIBC)/include
     
    -CINCLUDES-$(LIBNEWLIBGLUE) += -I$(LIBNEWLIBC_BASE)/include
    -CINCLUDES-$(LIBNEWLIBGLUE) += -I$(LIBNEWLIB_LIBC)/include
    -CXXINCLUDES-$(LIBNEWLIBGLUE) += -I$(LIBNEWLIBC_BASE)/include
    -CXXINCLUDES-$(LIBNEWLIBGLUE) += -I$(LIBNEWLIB_LIBC)/include
    -
     LIBNEWLIBM_CINCLUDES   += -I$(LIBNEWLIB_LIBM)/common
     LIBNEWLIBM_CXXINCLUDES += -I$(LIBNEWLIB_LIBM)/common
     
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel