Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH 2/6] syslog.h: Adapt to Unikraft

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Costin, Bogdan, this patch looks good, thanks.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 14.08.19, 20:57, "Costin Lupu" <costin.lupu@xxxxxxxxx> wrote:

    From: Bogdan Lascu <lascu.bogdan96@xxxxxxxxx>
    
    * Fix include
    * Add licenses
    
    Signed-off-by: Bogdan Lascu <lascu.bogdan96@xxxxxxxxx>
    Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
    ---
     musl-imported/include/sys/syslog.h | 24 ++++++++++++++++++++++++
     musl-imported/include/syslog.h     | 26 +++++++++++++++++++++++++-
     2 files changed, 49 insertions(+), 1 deletion(-)
    
    diff --git a/musl-imported/include/sys/syslog.h 
b/musl-imported/include/sys/syslog.h
    index 7761ece..852b347 100644
    --- a/musl-imported/include/sys/syslog.h
    +++ b/musl-imported/include/sys/syslog.h
    @@ -1 +1,25 @@
    +/* SPDX-License-Identifier: MIT */
    +/* ----------------------------------------------------------------------
    + * Copyright © 2005-2014 Rich Felker, et al.
    + *
    + * Permission is hereby granted, free of charge, to any person obtaining
    + * a copy of this software and associated documentation files (the
    + * "Software"), to deal in the Software without restriction, including
    + * without limitation the rights to use, copy, modify, merge, publish,
    + * distribute, sublicense, and/or sell copies of the Software, and to
    + * permit persons to whom the Software is furnished to do so, subject to
    + * the following conditions:
    + *
    + * The above copyright notice and this permission notice shall be
    + * included in all copies or substantial portions of the Software.
    + *
    + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
    + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
    + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
    + * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
    + * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
    + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
    + * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
    + * ----------------------------------------------------------------------
    + */
     #include <syslog.h>
    diff --git a/musl-imported/include/syslog.h b/musl-imported/include/syslog.h
    index 5b4d296..a5d312d 100644
    --- a/musl-imported/include/syslog.h
    +++ b/musl-imported/include/syslog.h
    @@ -1,3 +1,27 @@
    +/* SPDX-License-Identifier: MIT */
    +/* ----------------------------------------------------------------------
    + * Copyright © 2005-2014 Rich Felker, et al.
    + *
    + * Permission is hereby granted, free of charge, to any person obtaining
    + * a copy of this software and associated documentation files (the
    + * "Software"), to deal in the Software without restriction, including
    + * without limitation the rights to use, copy, modify, merge, publish,
    + * distribute, sublicense, and/or sell copies of the Software, and to
    + * permit persons to whom the Software is furnished to do so, subject to
    + * the following conditions:
    + *
    + * The above copyright notice and this permission notice shall be
    + * included in all copies or substantial portions of the Software.
    + *
    + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
    + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
    + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
    + * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
    + * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
    + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
    + * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
    + * ----------------------------------------------------------------------
    + */
     #ifndef _SYSLOG_H
     #define _SYSLOG_H
     
    @@ -5,7 +29,7 @@
     extern "C" {
     #endif
     
    -#include <features.h>
    +/* TODO #include <features.h> */
     
     #define LOG_EMERG   0
     #define LOG_ALERT   1
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel