Re: [Minios-devel] [UNIKRAFT PATCH v3 1/8] build: Support Makefile.rules for each library

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Sharan,

This patch looks good. As a minor point, I'm not sure what you mean by "common" 
file in the commit message, I might reword it slightly on upstream.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 12.08.19, 16:04, "Minios-devel on behalf of Sharan Santhanam" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
Sharan.Santhanam@xxxxxxxxx> wrote:

    The patch gives the option to a library developer to extend the default
    Unikraft build system with library specific definitions. This common
    file is included before processing of Makefile.uk
    
    Signed-off-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
    ---
     Makefile | 7 ++++++-
     1 file changed, 6 insertions(+), 1 deletion(-)
    
    diff --git a/Makefile b/Makefile
    index da9b2269..0570db51 100644
    --- a/Makefile
    +++ b/Makefile
    @@ -315,7 +315,12 @@ export HOSTCC_NOCCACHE HOSTCXX_NOCCACHE
     
################################################################################
     # We need to include this file early (before any rule is defined)
     # but after we have tried to load a .config and after having our tools 
defined
    -include $(CONFIG_UK_BASE)/support/build/Makefile.rules
    +$(foreach M,$(strip $(wildcard $(addsuffix Makefile.rules,\
    +      $(CONFIG_UK_BASE)/support/build/ $(CONFIG_UK_BASE)/lib/*/\
    +      $(CONFIG_UK_BASE)/plat/*/ $(ELIB_DIR)/ $(APP_DIR)/)\
    +         )),\
    +           $(info Include $(M));\
    +           $(eval include $(M)))
     
     
################################################################################
     # Clean targets that do not have any dependency on a configuration
    -- 
    2.20.1
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel