Re: [Minios-devel] [UNIKRAFT/LWIP PATCH v2 4/5] lwipopts.h: Use libc ioctl.h if available

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Costing, Bogdan, this patch looks ok.

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 16.08.19, 09:09, "Costin Lupu" <costin.lupu@xxxxxxxxx> wrote:

    From: Bogdan Lascu <lascu.bogdan96@xxxxxxxxx>
    
    If we do have a libc ioctl.h header then we should be using it because it
    usually contains a larger number of constants with better value assignments 
than
    the ones in lwip.
    
    Signed-off-by: Bogdan Lascu <lascu.bogdan96@xxxxxxxxx>
    Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
    ---
     include/lwipopts.h | 4 ++++
     1 file changed, 4 insertions(+)
    
    diff --git a/include/lwipopts.h b/include/lwipopts.h
    index c72c161..559223d 100644
    --- a/include/lwipopts.h
    +++ b/include/lwipopts.h
    @@ -187,6 +187,10 @@ void sys_free(void *ptr);
     #endif
     
     #if LWIP_SOCKET
    +#if CONFIG_HAVE_LIBC
    +/* Stop lwip to provide ioctl constants */
    +#include <sys/ioctl.h>
    +#endif
     /* Stop lwip to provide fd_set */
     #include <sys/select.h>
     
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel