Re: [Minios-devel] [UNIKRAFT PATCH 1/4] lib/ukcontext: Introduce libucontext library skeleton

[Costin Lupu <costin.lup@xxxxxxxxx>]

Hi Charalampos,

Please see my comments inline.

On 8/22/19 7:06 PM, Charalampos Mainas wrote:
> Signed-off by: Charalampos Mainas <charalampos.mainas@xxxxxxxxx>

s/Signed-off by/Signed-off-by/g

> ---
>  lib/Config.uk                |  1 +
>  lib/Makefile.uk              |  1 +
>  lib/ukucontext/Config.uk     |  4 +++
>  lib/ukucontext/Makefile.uk   | 47 ++++++++++++++++++++++++++++++++++++
>  lib/ukucontext/exportsyms.uk |  0
>  5 files changed, 53 insertions(+)
>  create mode 100644 lib/ukucontext/Config.uk
>  create mode 100644 lib/ukucontext/Makefile.uk
>  create mode 100644 lib/ukucontext/exportsyms.uk
> 
> diff --git a/lib/Config.uk b/lib/Config.uk
> index 204f5216..70c928af 100644
> --- a/lib/Config.uk
> +++ b/lib/Config.uk
> @@ -51,3 +51,4 @@ source "lib/uksglist/Config.uk"
>  source "lib/uknetdev/Config.uk"
>  source "lib/posix-libdl/Config.uk"
>  source "lib/uklibparam/Config.uk"
> +source "lib/ukucontext/Config.uk"
> diff --git a/lib/Makefile.uk b/lib/Makefile.uk
> index ac1e38bc..12522dbd 100644
> --- a/lib/Makefile.uk
> +++ b/lib/Makefile.uk
> @@ -28,3 +28,4 @@ $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/uksglist))
>  $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/uknetdev))
>  $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/posix-libdl))
>  $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/uklibparam))
> +$(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/ukucontext))
> diff --git a/lib/ukucontext/Config.uk b/lib/ukucontext/Config.uk
> new file mode 100644
> index 00000000..6234d9c7
> --- /dev/null
> +++ b/lib/ukucontext/Config.uk
> @@ -0,0 +1,4 @@
> +menuconfig LIBUCONTEXT
> +           bool "libucontext: ucontext.h API"
> +           default n
> +
> diff --git a/lib/ukucontext/Makefile.uk b/lib/ukucontext/Makefile.uk
> new file mode 100644
> index 00000000..0f92b6ca
> --- /dev/null
> +++ b/lib/ukucontext/Makefile.uk
> @@ -0,0 +1,47 @@
> +#  libucontext Makefile.uk
> +#
> +#  Authors: Charalampos Mainas <Charalampos.Mainas@xxxxxxxxx>
> +#
> +#   Copyright (c) 2019, NEC Europe Ltd., NEC Corporation. All rights 
> reserved.
> +#
> +#  Redistribution and use in source and binary forms, with or without
> +#  modification, are permitted provided that the following conditions
> +#  are met:
> +#
> +#  1. Redistributions of source code must retain the above copyright
> +#     notice, this list of conditions and the following disclaimer.
> +#  2. Redistributions in binary form must reproduce the above copyright
> +#     notice, this list of conditions and the following disclaimer in the
> +#     documentation and/or other materials provided with the distribution.
> +#  3. Neither the name of the copyright holder nor the names of its
> +#     contributors may be used to endorse or promote products derived from
> +#     this software without specific prior written permission.
> +#
> +#  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
> IS"
> +#  AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> +#  IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> +#  ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
> +#  LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> +#  CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> +#  SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> +#  INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> +#  CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> +#  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> +#  POSSIBILITY OF SUCH DAMAGE.
> +#
> +#  THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
> +#
> +
> +
> +################################################################################
> +# Library registration
> +################################################################################
> +$(eval $(call addlib_s,libucontext,$(CONFIG_LIBUCONTEXT)))
> +
> +################################################################################
> +# Library includes
> +################################################################################
> +CINCLUDES-$(CONFIG_LIBUCONTEXT)    += -I$(LIBUCONTEXT_BASE)/include      
> +CXXINCLUDES-$(CONFIG_LIBUCONTEXT)  += -I$(LIBUCONTEXT_BASE)/include      
> +
> +
> diff --git a/lib/ukucontext/exportsyms.uk b/lib/ukucontext/exportsyms.uk
> new file mode 100644
> index 00000000..e69de29b
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel