Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH 05/16] Add dl_iterate_phdr() stub

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Charlampos, this patch looks good, thanks.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 22.08.19, 12:11, "Costin Lupu" <costin.lupu@xxxxxxxxx> wrote:

    From: Charalampos Mainas <charalampos.mainas@xxxxxxxxx>
    
    Signed-off-by: Charalampos Mainas <charalampos.mainas@xxxxxxxxx>
    ---
     Makefile.uk |  1 +
     link.c      | 45 +++++++++++++++++++++++++++++++++++++++++++++
     2 files changed, 46 insertions(+)
     create mode 100644 link.c
    
    diff --git a/Makefile.uk b/Makefile.uk
    index f7e2b6e..54896c6 100644
    --- a/Makefile.uk
    +++ b/Makefile.uk
    @@ -117,6 +117,7 @@ LIBNEWLIBGLUE_SRCS-y += $(LIBNEWLIBC_BASE)/time.c|glue
     LIBNEWLIBGLUE_SRCS-y += $(LIBNEWLIBC_BASE)/locale.c
     LIBNEWLIBGLUE_SRCS-y += $(LIBNEWLIBC_BASE)/dev.c
     LIBNEWLIBGLUE_SRCS-y += $(LIBNEWLIBC_BASE)/signal.c
    +LIBNEWLIBGLUE_SRCS-y += $(LIBNEWLIBC_BASE)/link.c
     LIBNEWLIBGLUE_SRCS-y += $(LIBNEWLIBC_BASE)/musl-imported/src/syslog.c
     LIBNEWLIBGLUE_SRCS-y += 
$(LIBNEWLIBC_BASE)/musl-imported/src/termios/tcsetattr.c
     LIBNEWLIBGLUE_SRCS-y += 
$(LIBNEWLIBC_BASE)/musl-imported/src/termios/tcgetattr.c
    diff --git a/link.c b/link.c
    new file mode 100644
    index 0000000..204713e
    --- /dev/null
    +++ b/link.c
    @@ -0,0 +1,45 @@
    +/* SPDX-License-Identifier: BSD-3-Clause */
    +/*
    + * Authors: Charalampos Mainas <charalampos.mainas@xxxxxxxxx>
    + *
    + * Copyright (c) 2019, NEC Europe Ltd., NEC Corporation. All rights 
reserved.
    + *
    + * Redistribution and use in source and binary forms, with or without
    + * modification, are permitted provided that the following conditions
    + * are met:
    + *
    + * 1. Redistributions of source code must retain the above copyright
    + *    notice, this list of conditions and the following disclaimer.
    + * 2. Redistributions in binary form must reproduce the above copyright
    + *    notice, this list of conditions and the following disclaimer in the
    + *    documentation and/or other materials provided with the distribution.
    + * 3. Neither the name of the copyright holder nor the names of its
    + *    contributors may be used to endorse or promote products derived from
    + *    this software without specific prior written permission.
    + *
    + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
IS"
    + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 
THE
    + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
PURPOSE
    + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS 
BE
    + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
    + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
    + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
    + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
    + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
    + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
THE
    + * POSSIBILITY OF SUCH DAMAGE.
    + *
    + * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
    + */
    +
    +#include <uk/essentials.h>
    +#include <stddef.h>
    +#include <link.h>
    +
    +int dl_iterate_phdr(
    +           int (*callback)(struct dl_phdr_info *info,
    +                           size_t size, void *data),
    +           void *data)
    +{
    +   return 0;
    +}
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel