Re: [Minios-devel] [UNIKRAFT/LWIP PATCH v2 0/5] Add changes needed for Redis and OpenSSL

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Costin,

As described offline, the patch fails to apply because of different types of 
end of line characters. I'll fix this while upstreaming.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 20.08.19, 06:20, "Minios-devel on behalf of Felipe Huici" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of Felipe.Huici@xxxxxxxxx> 
wrote:

    HI Costin,
    
    As a summary, since the broken patch #3 is independent of the others, I've 
pushed the other 4 patches upstream. Please submit a new version for patch #3.
    
    -- Felipe
    
    On 16.08.19, 09:09, "Costin Lupu" <costin.lupu@xxxxxxxxx> wrote:
    
        The first two patches introduce the missing functions needed by Redis. 
The next
        two import getnameinfo() from OsV, this function being used by OpenSSL 
and
        depending on the first two patches.
        
        The last patch disables mem_* functions declarations in lwip for 
libraries
        other than lwip because they are also declared by OpenSSL with different
        prototypes. This patch depends on '[UNIKRAFT PATCH] build: Define
        preprocessing symbol for library name' which introduces library names as
        preprocessing symbols.
        
        Changes since v1:
        - Revisit the last 3 patches of v1
        - Add 2 more patches which fix some compiler warnings
        
        Costin Lupu (5):
          Import getnameinfo() function from OsV
          Adapt getnameinfo() function to Unikraft
          patches: Declare mem_* functions only for lwip internal use
          lwipopts.h: Use libc ioctl.h if available
          netdb.h: Add getservbyname() and getservbyport() declarations
        
         Makefile.uk                                   |   3 +
         exportsyms.uk                                 |   1 +
         getnameinfo.c                                 | 147 ++++++++++++++++++
         include/lwipopts.h                            |   4 +
         include/netdb.h                               |  26 ++++
         inet.c                                        |   2 +
         ...functions-only-for-lwip-internal-use.patch |  31 ++++
         7 files changed, 214 insertions(+)
         create mode 100644 getnameinfo.c
         create mode 100644 
patches/0003-Declare-mem_-functions-only-for-lwip-internal-use.patch
        
        -- 
        2.20.1
        
        
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel