Re: [Minios-devel] [UNIKRAFT/LIBLWIP PATCH v2 1/3] Makefile.uk: Guard socket-related source files.

[Costin Lupu <costin.lup@xxxxxxxxx>]

Thanks, Felipe!

Reviewed-by: Costin Lupu <costin.lupu@xxxxxxxxx>

On 9/3/19 11:03 AM, Felipe Huici wrote:
> Put compile guards around socket-related source files such that they
> do not get compiled if sockets are disabled.
> 
> Signed-off-by: Felipe Huici <felipe.huici@xxxxxxxxx>
> ---
>  Makefile.uk | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile.uk b/Makefile.uk
> index c2651d7..99fc062 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -72,16 +72,18 @@ LIBLWIP_CXXFLAGS-y += -D__IN_LIBLWIP__
>  # Core
>  
> ################################################################################
>  LIBLWIP_SRCS-y += $(LIBLWIP_BASE)/alloc.c|unikraft
> +ifeq ($(CONFIG_LWIP_SOCKET),y)
>  LIBLWIP_SRCS-y += $(LIBLWIP_BASE)/proto.c
>  LIBLWIP_SRCS-y += $(LIBLWIP_BASE)/host.c
>  LIBLWIP_SRCS-y += $(LIBLWIP_BASE)/serv.c
> +LIBLWIP_SRCS-y += $(LIBLWIP_BASE)/inet.c|unikraft
> +endif
>  LIBLWIP_SRCS-$(CONFIG_LWIP_THREADS) += $(LIBLWIP_BASE)/mutex.c|unikraft
>  LIBLWIP_SRCS-$(CONFIG_LWIP_THREADS) += $(LIBLWIP_BASE)/semaphore.c|unikraft
>  LIBLWIP_SRCS-$(CONFIG_LWIP_THREADS) += $(LIBLWIP_BASE)/mailbox.c|unikraft
>  LIBLWIP_SRCS-$(CONFIG_LWIP_THREADS) += $(LIBLWIP_BASE)/threads.c|unikraft
>  LIBLWIP_SRCS-y += $(LIBLWIP_BASE)/init.c|unikraft
>  LIBLWIP_SRCS-y += $(LIBLWIP_BASE)/time.c|unikraft
> -LIBLWIP_SRCS-y += $(LIBLWIP_BASE)/inet.c|unikraft
>  LIBLWIP_SRCS-$(CONFIG_LWIP_SOCKET) += $(LIBLWIP_BASE)/sockets.c|unikraft
>  LIBLWIP_SRCS-$(CONFIG_LWIP_SOCKET) += $(LIBLWIP_BASE)/getnameinfo.c|unikraft
>  LIBLWIP_SRCS-y += $(LIBLWIP_EXTRACTED)/core/init.c
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel