[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH] lib/ukswrand: Fix reading from devices


  • To: Costin Lupu <costin.lupu@xxxxxxxxx>, "minios-devel@xxxxxxxxxxxxx" <minios-devel@xxxxxxxxxxxxx>
  • From: Vlad-Andrei BĂDOIU (78692) <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
  • Date: Tue, 3 Sep 2019 11:55:22 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=stud.acs.upb.ro; dmarc=pass action=none header.from=stud.acs.upb.ro; dkim=pass header.d=stud.acs.upb.ro; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OhKUPAm6GYjsSUZ2c4RFOuyOR9E12jk7EKHZK2jNBvg=; b=mDpYX9FURH4CpwLswbVazwlQ+C0tNLLTmJM8R56R758cys9xO0O4NAH/H3hRLGT+/Ut7kAdAIDjc7kDZDx4w9LAfDsgwFMDrtyOmzOWgWfujKu29q+3uPnq/n9N8+6ThTlg5eLPiKvmwb0t4jSdJpSAk2c4KQ7VRL8ZL0kIALc+xV8M/wEM2W66DfQ63/yOB2vasZvBQbYgFHRn1Kzu31cSM/onmchRT7VP3TL/O6yunHB+QtA1Ighygv9oM+qNoHpChpFKBJsMLbMfd8gOoWMJe1OX0/pGcePKJ/8Y8FV7aM+9RK9XqRzoiUiFq3ky6H1son/lqOR5PYDe/rujfvA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EmSyVtXC3u4sdk28EpHqMqbic2hc2kOwuL5YwRMODF6H1Lv8oiIILbIV73CiDFLm6l/zKm7RAkM+AKvUSjJWo11/kW9cqIkvSikMfhvkURsF3VyPZrQoPR+Z10KJ0pS4RDQC+E4pRUz350yUzHgCoWCBaYOfJl9T4eBSJaGZggRfPOzYLy37FR/4tWFKqSTfNUwR0lRiqnRg2tmJXPKAgkHd7Xd1faPrVqEhBGfWyqw3DLBxCi/PKpgsMGXygrZYAl0LymYX7Fq0pbafg2fx3lltEBNh8k+KSkfwJXsDO+1UZr/fEkZ/lN2pYaIOm6ht2X1fTi7aykZSm0RO+PTmxA==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=vlad_andrei.badoiu@xxxxxxxxxxxxxxx;
  • Cc: Costin Lupu <costin.lup@xxxxxxxxx>
  • Delivery-date: Tue, 03 Sep 2019 11:55:28 +0000
  • List-id: Mini-os development list <minios-devel.lists.xenproject.org>
  • Thread-index: AQHVYi9ll5ppum+aJU6gdJ4Rc9RX7KcZ2IuA
  • Thread-topic: [UNIKRAFT PATCH] lib/ukswrand: Fix reading from devices

Hi Costin,

This patch looks good. Thanks!

Vlad

Reviewed-by: Vlad-Andrei Badoiu<vlad_andrei.badoiu@xxxxxxxxxxxxxxx>

On 03.09.2019 11:12, Costin Lupu wrote:
> From: Costin Lupu <costin.lup@xxxxxxxxx>
>
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> ---
>   lib/ukswrand/mwc_dev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/ukswrand/mwc_dev.c b/lib/ukswrand/mwc_dev.c
> index 5a9c0d49..5a4cb100 100644
> --- a/lib/ukswrand/mwc_dev.c
> +++ b/lib/ukswrand/mwc_dev.c
> @@ -60,7 +60,7 @@ int dev_random_read(struct device *dev __unused, struct uio 
> *uio,
>       chunk_size = count % step;
>   
>       for (i = 0; i < count - chunk_size; i += step)
> -             *((__u32 *)buf + i) = uk_swrand_randr();
> +             *(buf + i) = uk_swrand_randr();
>   
>       /* fill the remaining bytes of the buffer */
>       if (chunk_size > 0) {
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.