Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH] Update fcntl() related definitions

[Vlad-Andrei BĂDOIU (78692) <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>]

Hi Costin,

This patch looks good. Thanks!

Vlad

[1]https://github.com/cloudius-systems/osv/blob/master/tests/tst-fcntl.cc

On 04.09.2019 17:59, Costin Lupu wrote:
> Since we are using the fcntl() implementation in vfscore, we don't use 
> newlib's
> any more. This patch also adds some flags that are needed by fcntl() and that
> were copied from musl, just like the previous ones from fcntl.h.
>
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> ---
>   Makefile.uk     |  2 +-
>   include/fcntl.h | 13 ++++++++++---
>   2 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile.uk b/Makefile.uk
> index c02c2f0..01da724 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -792,7 +792,7 @@ LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/string/wcsdup.c
>   
> ################################################################################
>   # Newlib/libc code -- syscalls
>   
> ################################################################################
> -LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/syscalls/sysfcntl.c
> +#LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/syscalls/sysfcntl.c
>   
>   
> ################################################################################
>   # Newlib/libc code -- time
> diff --git a/include/fcntl.h b/include/fcntl.h
> index 25a4808..7a35052 100644
> --- a/include/fcntl.h
> +++ b/include/fcntl.h
> @@ -11,15 +11,22 @@
>   #define O_DIRECTORY 0200000
>   #define O_CLOEXEC  02000000
>   #define O_DSYNC      010000
> -#endif
> -
> -#if ((defined CONFIG_ARCH_ARM_64) || (defined CONFIG_ARCH_ARM_32))
> +#define O_ASYNC      020000
> +#define O_DIRECT     040000
> +#define O_NOATIME  01000000
> +#elif ((defined CONFIG_ARCH_ARM_64) || (defined CONFIG_ARCH_ARM_32))
>   #define O_NOFOLLOW  0100000
>   #define O_DIRECTORY  040000
>   #define O_CLOEXEC  02000000
>   #define O_DSYNC      010000
> +#define O_ASYNC      020000
> +#define O_DIRECT    0200000
> +#define O_NOATIME  01000000
>   #endif
>   
> +#define FIONBIO      0x5421
> +#define FIOASYNC     0x5452
> +
>   
>   /* Glibc does not provide KEEP_SIZE and PUNCH_HOLE anymore. Instead it
>    * includes linux/falloc.h.
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel