[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Minios-devel] [UNIKRAFT PATCH 3/9] plat/xen/drivers/9p: Initialize xenbus device


  • To: "minios-devel@xxxxxxxxxxxxx" <minios-devel@xxxxxxxxxxxxx>
  • From: Vlad-Andrei BĂDOIU (78692) <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
  • Date: Sat, 7 Sep 2019 10:21:57 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=stud.acs.upb.ro; dmarc=pass action=none header.from=stud.acs.upb.ro; dkim=pass header.d=stud.acs.upb.ro; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IOpulg8WxFBJ2Wq/fQUFf+eNFjHAiCEmm9yNNeNdtHk=; b=TEMiDQmiu7Y9QmJo6RdBKU6BjoKlurMFXLFAWwDLSMKCL0FECSjW7pB8yLmv0MJnTdrj9yQC301KtdTCf1CyiHhGziuSo/w3QFfHOqM5Q3N8UHnckgfS15X30z1T6imbEHRO2bAIQS2GdLGHmCdCWdDbU8lBMSEkmWUDQHnAwbbGdqwolONX+yFz7ssHM9zIMMOHS8klTdnbSqJ2rc9rzgvqy8cSc03yF1YGGe+8rpR/2uTByRMFL3wTCmV2LnKPt7rdKikB2ZbcwMeHnTqBmBKLPzmbTahIjHzJhHCZRmPJXcz0s1CmYkzcUfHJd5aJcHdlRICU47G/vZEKnZ/4Bg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YtKCP1cx6j2A8DS27wHuoSwbqDc75lLhcCucjF4KDomC3qsgDJ909ZroF+zX9bLkSkEUNXNF288ELipXmDleQu3tPT/vDgF6W9nkuQaiLYJlJM2+0ZeHHKd+NnoKsat1RQyIlc/MOBOyLG3lIVUO/YaVRKLeBzTYRJe6WF5za17aK9cK9pXvHgcvB/MgKRHCdDJf74LSz/fBXX/twG2WbYEmeLsQDIG76Vh8NY2HG8P1qZAUyXoDybenQKzQRIDI9icC84+kBjHKnPyRfw/zTH4RchmYlwI/VnDLAzb2E9kIXug5AU8tu5ULejHWQ1NW9Tq0Xjz2iRfgxUYbb1C+Ng==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=vlad_andrei.badoiu@xxxxxxxxxxxxxxx;
  • Cc: "costin.lupu@xxxxxxxxx" <costin.lupu@xxxxxxxxx>, Cristian Banu <cristb@xxxxxxxxx>
  • Delivery-date: Sat, 07 Sep 2019 10:22:10 +0000
  • List-id: Mini-os development list <minios-devel.lists.xenproject.org>
  • Thread-index: AQHVZWYUk7BRbcEeGUC22SoxVNyAGw==
  • Thread-topic: [UNIKRAFT PATCH 3/9] plat/xen/drivers/9p: Initialize xenbus device

From: Cristian Banu <cristb@xxxxxxxxx>

This patch adds the xenbus function responsible for reading data written
by the toolstack and the backend from the xenstore, required for
initializing a 9pfront device.

Signed-off-by: Cristian Banu <cristb@xxxxxxxxx>
---
 plat/xen/Makefile.uk             |   1 +
 plat/xen/drivers/9p/9pfront.h    |  53 +++++++++++
 plat/xen/drivers/9p/9pfront_xb.h |  53 +++++++++++
 plat/xen/drivers/9p/9pfront_xs.c | 156 +++++++++++++++++++++++++++++++
 4 files changed, 263 insertions(+)
 create mode 100644 plat/xen/drivers/9p/9pfront.h
 create mode 100644 plat/xen/drivers/9p/9pfront_xb.h
 create mode 100644 plat/xen/drivers/9p/9pfront_xs.c

diff --git a/plat/xen/Makefile.uk b/plat/xen/Makefile.uk
index 9dbc7725..1d7e7cff 100644
--- a/plat/xen/Makefile.uk
+++ b/plat/xen/Makefile.uk
@@ -119,4 +119,5 @@ LIBXEN9PFRONT_ASINCLUDES-y     += $(LIBXENPLAT_ASINCLUDES-y)
 LIBXEN9PFRONT_CFLAGS-y         += $(LIBXENPLAT_CFLAGS-y)
 LIBXEN9PFRONT_CINCLUDES-y      += $(LIBXENPLAT_CINCLUDES-y)
 LIBXEN9PFRONT_SRCS-y           += $(LIBXENPLAT_BASE)/drivers/9p/9pfront.c
+LIBXEN9PFRONT_SRCS-y           += $(LIBXENPLAT_BASE)/drivers/9p/9pfront_xs.c
 endif
diff --git a/plat/xen/drivers/9p/9pfront.h b/plat/xen/drivers/9p/9pfront.h
new file mode 100644
index 00000000..0dd99d6c
--- /dev/null
+++ b/plat/xen/drivers/9p/9pfront.h
@@ -0,0 +1,53 @@
+/* SPDX-License-Identifier: BSD-3-Clause */
+/*
+ * Authors: Cristian Banu <cristb@xxxxxxxxx>
+ *
+ * Copyright (c) 2019, University Politehnica of Bucharest. All rights 
reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ * 3. Neither the name of the copyright holder nor the names of its
+ *    contributors may be used to endorse or promote products derived from
+ *    this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
+ */
+
+#ifndef __9PFRONT_H__
+#define __9PFRONT_H__
+
+#include <uk/config.h>
+#include <uk/essentials.h>
+#include <uk/list.h>
+
+struct p9front_dev {
+       /* Xenbus device. */
+       struct xenbus_device *xendev;
+       /* Number of maximum rings, read from xenstore. */
+       int nb_max_rings;
+       /* Maximum ring page order, read from xenstore. */
+       int max_ring_page_order;
+       /* Mount tag for this device, read from xenstore. */
+       char *tag;
+};
+
+#endif /* __9PFRONT_H__ */
diff --git a/plat/xen/drivers/9p/9pfront_xb.h b/plat/xen/drivers/9p/9pfront_xb.h
new file mode 100644
index 00000000..224df7af
--- /dev/null
+++ b/plat/xen/drivers/9p/9pfront_xb.h
@@ -0,0 +1,53 @@
+/* SPDX-License-Identifier: BSD-3-Clause */
+/*
+ * Authors: Cristian Banu <cristb@xxxxxxxxx>
+ *
+ * Copyright (c) 2019, University Politehnica of Bucharest. All rights 
reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ * 3. Neither the name of the copyright holder nor the names of its
+ *    contributors may be used to endorse or promote products derived from
+ *    this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
+ */
+
+#ifndef __9PFRONT_XB_H__
+#define __9PFRONT_XB_H__
+
+#include "9pfront.h"
+
+/**
+ * Reads device information from the xenstore, such as the mount tag
+ * and details about the device rings.
+ *
+ * @param p9fdev
+ *   9P frontend device
+ * @return
+ *   - (0): Successful.
+ *   - (-EINVAL): Invalid data.
+ *   - (< 0): Error while reading.
+ */
+int p9front_xb_init(struct p9front_dev *p9fdev);
+
+#endif /* __9PFRONT_XB_H__ */
diff --git a/plat/xen/drivers/9p/9pfront_xs.c b/plat/xen/drivers/9p/9pfront_xs.c
new file mode 100644
index 00000000..5b5dc2e4
--- /dev/null
+++ b/plat/xen/drivers/9p/9pfront_xs.c
@@ -0,0 +1,156 @@
+/* SPDX-License-Identifier: BSD-3-Clause */
+/*
+ * Authors: Cristian Banu <cristb@xxxxxxxxx>
+ *
+ * Copyright (c) 2019, University Politehnica of Bucharest. All rights 
reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ * 3. Neither the name of the copyright holder nor the names of its
+ *    contributors may be used to endorse or promote products derived from
+ *    this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
+ */
+
+#include <string.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <uk/config.h>
+#include <uk/assert.h>
+#include <uk/essentials.h>
+#include <uk/errptr.h>
+#include <xenbus/xs.h>
+#include <xenbus/client.h>
+
+#include "9pfront_xb.h"
+
+static int xs_read_backend_info(struct xenbus_device *xendev)
+{
+       int rc, val;
+       char path[strlen(xendev->nodename) + sizeof("/backend-id")];
+
+       /* Read backend id. */
+       sprintf(path, "%s/backend-id", xendev->nodename);
+       rc = xs_read_integer(XBT_NIL, path, &val);
+       if (rc)
+               goto out;
+       xendev->otherend_id = (domid_t)val;
+
+       /* Read backend path. */
+       xendev->otherend = xs_read(XBT_NIL, xendev->nodename, "backend");
+       if (PTRISERR(xendev->otherend)) {
+               rc = PTR2ERR(xendev->otherend);
+               xendev->otherend = NULL;
+       }
+
+out:
+       return rc;
+}
+
+static int xs_read_backend_ring_info(struct xenbus_device *xendev,
+                                    int *nb_max_rings,
+                                    int *max_ring_page_order)
+{
+       int rc;
+       char *int_str;
+
+       /* Read max-rings. */
+       int_str = xs_read(XBT_NIL, xendev->otherend, "max-rings");
+       if (PTRISERR(int_str)) {
+               rc = PTR2ERR(int_str);
+               uk_pr_err("Error: %d\n", rc);
+               goto out;
+       }
+
+       *nb_max_rings = strtol(int_str, NULL, 10);
+       free(int_str);
+
+       /* Read max-ring-page-order. */
+       int_str = xs_read(XBT_NIL, xendev->otherend, "max-ring-page-order");
+       if (PTRISERR(int_str)) {
+               rc = PTR2ERR(int_str);
+               uk_pr_err("Error: %d\n", rc);
+               goto out;
+       }
+
+       *max_ring_page_order = strtol(int_str, NULL, 10);
+       free(int_str);
+       rc = 0;
+
+out:
+       return rc;
+}
+
+int p9front_xb_init(struct p9front_dev *p9fdev)
+{
+       struct xenbus_device *xendev;
+       char *versions;
+       int rc;
+
+       UK_ASSERT(p9fdev != NULL);
+
+       xendev = p9fdev->xendev;
+       UK_ASSERT(xendev != NULL);
+
+       /* Read backend node and backend id. */
+       rc = xs_read_backend_info(xendev);
+       if (rc) {
+               uk_pr_err("Error initializing backend node and id.\n");
+               goto out;
+       }
+
+       /* Check versions string. */
+       versions = xs_read(XBT_NIL, xendev->otherend, "versions");
+       if (PTRISERR(versions)) {
+               uk_pr_err("Error reading backend version information.\n");
+               rc = PTR2ERR(versions);
+               goto out;
+       }
+
+       if (strcmp(versions, "1")) {
+               uk_pr_err("Backend does not support xen protocol version 1.\n");
+               free(versions);
+               rc = -EINVAL;
+               goto out;
+       }
+       free(versions);
+
+       /* Read ring information. */
+       rc = xs_read_backend_ring_info(xendev, &p9fdev->nb_max_rings,
+                                      &p9fdev->max_ring_page_order);
+       if (rc) {
+               uk_pr_err("Error reading backend ring information.\n");
+               goto out;
+       }
+
+       /* Read tag. */
+       p9fdev->tag = xs_read(XBT_NIL, xendev->nodename, "tag");
+       if (PTRISERR(p9fdev->tag)) {
+               uk_pr_err("Error reading 9pfs mount tag.\n");
+               rc = PTR2ERR(p9fdev->tag);
+               p9fdev->tag = NULL;
+       }
+
+out:
+       return rc;
+}
-- 
2.20.1


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.