Re: [Minios-devel] [UNIKRAFT PATCH 1/3] lib/vfscore: Use a scalable bitmap for open file descriptors

[Costin Lupu <costin.lup@xxxxxxxxx>]

Hi Sharan,

Thanks for reviewing this series.

On 9/5/19 4:15 PM, Sharan Santhanam wrote:
> Hello Costin,
> 
> Please find the comment inline.
> 
> Thanks & Regards
> 
> Sharan
> 
> On 9/2/19 3:22 PM, Costin Lupu wrote:
>> Until now, the number of open file descriptors was limited to 64,
>> which was the
>> number of bits of the underlying bitmap. We fix that by replacing with a
>> configurable bitmap. We set the default value of maximum open files to
>> 1024.
>>
>> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
>> ---
>>   lib/vfscore/Config.uk |  8 +++++++-
>>   lib/vfscore/fd.c      | 16 ++++++++--------
>>   2 files changed, 15 insertions(+), 9 deletions(-)
>>
>> diff --git a/lib/vfscore/Config.uk b/lib/vfscore/Config.uk
>> index 6cf6c63a..07319099 100644
>> --- a/lib/vfscore/Config.uk
>> +++ b/lib/vfscore/Config.uk
>> @@ -1,6 +1,12 @@
>> -config LIBVFSCORE
>> +menuconfig LIBVFSCORE
>>       bool "vfscore: VFS Core Interface"
>>       default n
>>       select LIBNOLIBC if !HAVE_LIBC
>>       select LIBUKDEBUG
>>       select LIBUKLOCK
>> +
>> +if LIBVFSCORE
>> +config LIBVFSCORE_MAX_FILES
>> +    int "Maximum number of open files"
>> +    default 1024
>> +endif
> Do we want to define max file descriptor as configuration in Config.uk?
> From a user perspective it might not always be possible to determine
> this value before hand. We might add support for ulimit instead of keep
> is compile time configuration. I would rather we pick a default value
> for now and if a need arise we make it configurable then.

Alright, I'll get rid of this LIBVFSCORE_MAX_FILES in v2.

Cheers,
Costin

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel