Re: [Minios-devel] [UNIKRAFT PATCH v2 4/6] lib/ramfs: Config.uk: Use select for dependency

[Costin Lupu <costin.lup@xxxxxxxxx>]

Hi Simon,

In order to understand the current logic for the filesystem options in
menuconfig, you should read the 'vfscore: ...' option as 'Filesystems'
(and maybe it should be renamed that way). So, in order to reach
selecting ramfs you should first select 'Filesystems' support. Applying
your patch now would put ramfs on the same level as 'vfscore: ...' which
would make it unnecessary.

On 9/6/19 3:03 PM, Simon Kuenzer wrote:
> Use `select` instead of `depends on` which makes the filesystem
> library existence more obvious within the menu.
> 
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
>  lib/ramfs/Config.uk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/ramfs/Config.uk b/lib/ramfs/Config.uk
> index 52e4388c..b8d98936 100644
> --- a/lib/ramfs/Config.uk
> +++ b/lib/ramfs/Config.uk
> @@ -1,4 +1,4 @@
>  config LIBRAMFS
>       bool "ramfs: simple RAM file system"
>       default n
> -     depends on LIBVFSCORE
> +     select LIBVFSCORE
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel