Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH 2/4] bits/signal.h: Adapt to unikraft

[Costin Lupu <costin.lup@xxxxxxxxx>]

I will disable the declaration using `#if 0` instead of C++ comments on
upstreaming.

Reviewed-by: Costin Lupu <costin.lupu@xxxxxxxxx>

On 9/4/19 1:25 PM, Charalampos Mainas wrote:
> struct sigaltstack is already defined from newlib's sys/signal.h which
> is included from ucontext.h. To avoid redinition error while compiling, 
> struct sigaltstack is commented out.
> 
> Signed-off-by: Charalampos Mainas <Charalampos.Mainas@xxxxxxxxx>
> ---
>  musl-imported/arch/x86_64/bits/signal.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/musl-imported/arch/x86_64/bits/signal.h 
> b/musl-imported/arch/x86_64/bits/signal.h
> index 20cbf4a..f3b9efd 100644
> --- a/musl-imported/arch/x86_64/bits/signal.h
> +++ b/musl-imported/arch/x86_64/bits/signal.h
> @@ -60,11 +60,11 @@ typedef struct {
>  } mcontext_t;
>  #endif
>  
> -struct sigaltstack {
> -     void *ss_sp;
> -     int ss_flags;
> -     size_t ss_size;
> -};
> +//struct sigaltstack {
> +//   void *ss_sp;
> +//   int ss_flags;
> +//   size_t ss_size;
> +//};
>  
>  typedef struct __ucontext {
>       unsigned long uc_flags;
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel