[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH 1/1] patches: Allow including custom time.h headers


  • To: Vlad-Andrei BĂDOIU (78692) <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>, "minios-devel@xxxxxxxxxxxxx" <minios-devel@xxxxxxxxxxxxx>
  • From: Costin Lupu <costin.lupu@xxxxxxxxx>
  • Date: Thu, 12 Sep 2019 17:20:58 +0300
  • Delivery-date: Thu, 12 Sep 2019 14:21:05 +0000
  • Ironport-phdr: 9a23:NFZvYB8hDM2Um/9uRHKM819IXTAuvvDOBiVQ1KB+0+wWIJqq85mqBkHD//Il1AaPAdyAraoZwLWP++C4ACpcuMzH6ChDOLV3FDY9wf0MmAIhBMPXQWbaF9XNKxIAIcJZSVV+9Gu6O0UGUOz3ZlnVv2HgpWVKQka3OgV6PPn6FZDPhMqrye+y54fTYwJVjzahfL9+Nhq7oRjfu8UMnYdvKqk9xxnUrnBVf+ha2X5kKUickhrh+Mu85oJv/zhVt/k868NOTKL2crgiQ7dFFjomKWc15MPqtRnHUwSC42YXX3sVnBRVHQXL9Qn2UZjtvCT0sOp9wzSaMtbtTb8oQzSi7rxkRwHuhSwaKjM26mDXish3jKJGvBKsogF0zoDIbI2JMvd1Y7jQds0GS2VfQslRVjRBAoKiYIsJE+oBJvtTo43kq1cTsReyGQygCeXywTFKm3D2x7U33fk/HwHI3AIuHNwAv3rbo9r3KKgcXvu4zLXRzTjZc/9axTnw5YrOfxs8of+MR7Vwcc/JxEQxEAPFlUmQqY3jPziI0OoNrnCb7/d9Xu+ol2EnrBpxoiSuxscqkIXJgp8VykjZ9Shi3Ik1Pse0SFZmYdG/CpdQrSaaOpJwT8g/TW9ovyM6xacHuZ69ZCULx4ooxxjHa/yddIiI4AzsW/qNITtig3JlYr2/ihCv+kaj0u3xTtS43VlXoiZfkdTBtmoB2wLN5sWFUPdw8F+t1SuM2g3Q8O1IP0A5mbDFJ5MuwrM8jJUevEDFEyTrgkv5lrWWeV8h+uWw7uTnZajpqYGEOo9vjwH+LrwumsuiAeQkKgQOX3aU+eC71LD74035Ra9FjvwykqXDrJ/aPt4XprakAwBOyIoj8RG/Ay+n0NQeg3YHMEpIdA+IgoT0IV3DI/D1Ae2hj1iykjpn3f7LMqXkAprXL3jDlLnhfax6605Z0Ac80ddf54lICrEAJvL/QEvxtMHADh8kKAG73/3nBM9l1oMDQm2DGLWZMKTKvV+S+u0vO/WMZJMSuDvlLvgl5vjujX4+mV8GZKWmwIUYaG6mEfRiOEiZZXvsgswdEWcRpAY/Q/LliFuYXT5UfXayULo25isnB4K+EYfDWoetjaSf3Ce/BJJZe3hJBUqKEXj1bYWLRfYMZDiJLcB7jzMEUrmhS5I62BG1qA/61qdoIvDO9SIErpLvzsV15/XImh0o7zx0CJfV72bYcWV9kiYhQTMs0aFIi+dR7Xa+5ugn06IJT50bs+1NWwsNPJjQ1eF7Tdr7VgXAY/+SVEuqBNytGncsVth32dhYJw43HtSkjxfYmianHbIRv7iKH4AvtLLR2T72Pck3gyLD1a8giEJjTsZROGmOgq9k6xOVF4PP1UKDmPD5W74b2Xvm83yfzGzGmFxATUYkWqLeQXEZIE/LtcnR7ViEV6KkT64gZFgSgfWeI7dHP4W6xW5NQ+3ubZGHOzq8
  • Ironport-sdr: zBeuR+bblyTJ5WY1MF4juzXfjB93w4Gh3UR22AZ8egtqdXc7AwmuFxYCB/lldBr/XWL8Ax+Bk4 x7Y8nbEGGtNA==
  • List-id: Mini-os development list <minios-devel.lists.xenproject.org>

I'm revisiting this. Actually, after the small changes I made on patch
'lib/uktime: Adapt timegm implementation to Unikraft', this patch is not
needed anymore.

Cheers,
Costin

On 9/12/19 2:54 PM, Costin Lupu wrote:
> Thanks for the patch, Vlad!
> 
> Reviewed-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> 
> On 9/12/19 2:29 PM, Vlad-Andrei BĂDOIU (78692) wrote:
>> Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
>> ---
>>  ...atch-in-order-to-include-custom-time.patch | 27 +++++++++++++++++++
>>  1 file changed, 27 insertions(+)
>>  create mode 100644 
>> patches/0009-Apply-hackish-patch-in-order-to-include-custom-time.patch
>>
>> diff --git 
>> a/patches/0009-Apply-hackish-patch-in-order-to-include-custom-time.patch 
>> b/patches/0009-Apply-hackish-patch-in-order-to-include-custom-time.patch
>> new file mode 100644
>> index 0000000..559aed4
>> --- /dev/null
>> +++ b/patches/0009-Apply-hackish-patch-in-order-to-include-custom-time.patch
>> @@ -0,0 +1,27 @@
>> +From 0681ed5f288093affbd72f34c97cdc0be1c7f4c7 Mon Sep 17 00:00:00 2001
>> +From: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
>> +Date: Thu, 12 Sep 2019 13:44:45 +0300
>> +Subject: [PATCH 1/1] Apply hackish patch in order to include custom time.h
>> + header first
>> +
>> +Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
>> +---
>> + newlib/libc/include/time.h | 3 +++
>> + 1 file changed, 3 insertions(+)
>> +
>> +diff --git a/newlib/libc/include/time.h b/newlib/libc/include/time.h
>> +index 32baed9..f143b7c 100644
>> +--- a/newlib/libc/include/time.h
>> ++++ b/newlib/libc/include/time.h
>> +@@ -315,5 +315,8 @@ int _EXFUN(clock_getenable_attr, (clockid_t clock_id, 
>> int *attr));
>> + }
>> + #endif
>> + 
>> ++#else
>> ++#include_next <time.h>
>> ++
>> + #endif /* _TIME_H_ */
>> + 
>> +-- 
>> +2.20.1
>> +
>>
> 
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.