Re: [Minios-devel] [ UNIKRAFT/HTTP_PARSER PATCH v2 0/3] Initial port of http-parser to Unikraft

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Hey Santiago, hey Felipe,

I think this patch series looks already good. I have just some minor 
comments (inline). I think the library could be a "best practice" 
example due to its simplicity.
Thanks,

Simon

On 05.09.19 15:12, Santiago Pagani wrote:
> This is our initial port of http-parser to Unikraft as an external
> library. Newlibc is required.
>
> Tested with 'test.c' supported by the library. Almost all test are
> passing, with the exception of 'test very large chunked response'
> the 'response scan ...' tests.
>
> Changes since v1:
> - Edited Config.uk to use 'config' instead of 'menuconfig'
> - Edited Config.uk and changed the 'select HAVE_LIBC' to 'select LIBNEWLIBC' as 
> it depends newlib
> - Edited Config.uk and changed white spaces for tabs
> - Edited Makefile.uk to change the name of the library from 'http_parser' to 
> 'libhttp_parser'
> - Edited Makefile.uk to remove the /include folder as there is none in the 
> archive
>
> Santiago Pagani (3):
>    Introduce library skeleton
>    Add Makefile.uk
>    Export symbols
>
>   CODING_STYLE.md |  4 ++++
>   CONTRIBUTING.md |  4 ++++
>   COPYING.md      | 39 +++++++++++++++++++++++++++++++
>   Config.uk       |  4 ++++
>   MAINTAINERS.md  | 11 +++++++++
>   Makefile.uk     | 62 +++++++++++++++++++++++++++++++++++++++++++++++++
>   README.md       |  5 ++++
>   exportsyms.uk   | 14 +++++++++++
>   8 files changed, 143 insertions(+)
>   create mode 100644 CODING_STYLE.md
>   create mode 100644 CONTRIBUTING.md
>   create mode 100644 COPYING.md
>   create mode 100644 Config.uk
>   create mode 100644 MAINTAINERS.md
>   create mode 100644 Makefile.uk
>   create mode 100644 README.md
>   create mode 100644 exportsyms.uk
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel