Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH] Remove umask, fchown, lchown, rename

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Simon,

Thanks for the patch, that fixes the problem with the libvfscore patch. I'll 
approve the other one too and upstream them together.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 18.09.19, 14:23, "Simon Kuenzer" <simon.kuenzer@xxxxxxxxx> wrote:

    Removes the stubs `umask`, `fchown`, and `lchown` that are provided by
    the glue code. These functions are provided by libvfscore in the
    meantime. libvfscore also provides an implementation for
    `rename`. Because of this, we are stop building newlibc's version of it.
    
    Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
    ---
     Makefile.uk |  1 -
     file.c      | 17 -----------------
     2 files changed, 18 deletions(-)
    
    diff --git a/Makefile.uk b/Makefile.uk
    index 812f602..95b919a 100644
    --- a/Makefile.uk
    +++ b/Makefile.uk
    @@ -461,7 +461,6 @@ LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdio/putchar_u.c
     LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdio/puts.c
     LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdio/refill.c
     LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdio/remove.c
    -LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdio/rename.c
     LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdio/rewind.c
     LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdio/rget.c
     LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdio/scanf.c
    diff --git a/file.c b/file.c
    index 7d78f79..006f191 100644
    --- a/file.c
    +++ b/file.c
    @@ -54,11 +54,6 @@ extern int errno;
     #define STDOUT_FILENO   1       /* standard output file descriptor */
     #define STDERR_FILENO   2       /* standard error file descriptor */
     
    -mode_t umask(mode_t cmask __unused)
    -{
    -   return 0;
    -}
    -
     #include <sys/mman.h>
     void *mmap(void *addr __unused, size_t len __unused, int prot __unused,
                int flags __unused, int fildes __unused, off_t off __unused)
    @@ -96,18 +91,6 @@ int select(int nfds, fd_set *readfds __unused, fd_set 
*writefds __unused,
     }
     #endif /* !CONFIG_LWIP_SOCKET */
     
    -int fchown(int fd __unused, uid_t owner __unused, gid_t group __unused)
    -{
    -   return 0;
    -}
    -
    -int lchown(const char *pathname __unused, uid_t owner __unused,
    -           gid_t group __unused)
    -{
    -   return 0;
    -}
    -
    -
     int utimes(const char *filename __unused,
                const struct timeval times[2] __unused)
     {
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel