Re: [Minios-devel] [UNIKRAFT PATCH v3 11/23] kconfig: Fixdep and host flags

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Sharan,

This patch looks ok.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 19.09.19, 11:17, "Minios-devel on behalf of Sharan Santhanam" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
Sharan.Santhanam@xxxxxxxxx> wrote:

    Add CFLAGS, LDFLAGS, include paths and fixdep flags as a part of the
    host_cflags. The host_cflags are used to detect if there was changes to
    these flags.
    
    Signed-off-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
    ---
     support/kconfig.new/Makefile.br                       |  6 +++++-
     support/kconfig.new/patches/08-fixdep-and-config-flag | 19 
+++++++++++++++++++
     2 files changed, 24 insertions(+), 1 deletion(-)
     create mode 100644 support/kconfig.new/patches/08-fixdep-and-config-flag
    
    diff --git a/support/kconfig.new/Makefile.br 
b/support/kconfig.new/Makefile.br
    index 8e64a9b..ed9a5cf 100644
    --- a/support/kconfig.new/Makefile.br
    +++ b/support/kconfig.new/Makefile.br
    @@ -42,9 +42,13 @@ host-cobjs := $(addprefix $(obj)/,$(host-cobjs))
     host-cxxobjs := $(addprefix $(obj)/,$(host-cxxobjs))
     fixdep-objs := $(obj)/fixdep.o
     
    -HOST_EXTRACFLAGS += -I$(obj) -DCONFIG_=\"\"
    +HOST_EXTRACFLAGS += -I$(src) -I$(obj) -DCONFIG_=\"\"
     
    +_hostc_flags = $(HOSTCFLAGS) $(HOST_EXTRACFLAGS) 
$(HOSTCFLAGS_$(basetarget).o)
    +_hostcxx_flags = $(HOSTCXXFLAGS) $(HOST_EXTRACFLAGS) 
$(HOSTCXXFLAGS_$(basetarget).o)
     
    +hostc_flags    = -Wp,-MD,$(depfile) $(_hostc_flags)
    +hostcxx_flags  = -Wp,-MD,$(depfile) $(_hostcxx_flags)
     
     $(obj)/fixdep: $(fixdep-objs)
        $(HOSTCC) $(HOST_EXTRACFLAGS) $(HOSTCFLAGS) $(HOSTCFLAGS_$(@F)) $< -o $@
    diff --git a/support/kconfig.new/patches/08-fixdep-and-config-flag 
b/support/kconfig.new/patches/08-fixdep-and-config-flag
    new file mode 100644
    index 0000000..4a3a358
    --- /dev/null
    +++ b/support/kconfig.new/patches/08-fixdep-and-config-flag
    @@ -0,0 +1,19 @@
    +diff --git a/support/kconfig.new/Makefile.br 
b/support/kconfig.new/Makefile.br
    +index 29dee5e..9c11293 100644
    +--- a/support/kconfig.new/Makefile.br
    ++++ b/support/kconfig.new/Makefile.br
    +@@ -42,9 +42,13 @@ host-cobjs := $(addprefix $(obj)/,$(host-cobjs))
    + host-cxxobjs := $(addprefix $(obj)/,$(host-cxxobjs))
    + fixdep-objs := $(obj)/fixdep.o
    + 
    +-HOST_EXTRACFLAGS += -I$(obj) -DCONFIG_=\"\"
    ++HOST_EXTRACFLAGS += -I$(src) -I$(obj) -DCONFIG_=\"\"
    + 
    ++_hostc_flags = $(HOSTCFLAGS) $(HOST_EXTRACFLAGS) 
$(HOSTCFLAGS_$(basetarget).o)
    ++_hostcxx_flags = $(HOSTCXXFLAGS) $(HOST_EXTRACFLAGS) 
$(HOSTCXXFLAGS_$(basetarget).o)
    + 
    ++hostc_flags    = -Wp,-MD,$(depfile) $(_hostc_flags)
    ++hostcxx_flags  = -Wp,-MD,$(depfile) $(_hostcxx_flags)
    + 
    + $(obj)/fixdep: $(fixdep-objs)
    +   $(HOSTCC) $(HOST_EXTRACFLAGS) $(HOSTCFLAGS) $(HOSTCFLAGS_$(@F)) $< -o $@
    -- 
    2.7.4
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel