Re: [Minios-devel] [UNIKRAFT PATCH v3 19/23] build: Support syncconfig with kconfiglib

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Sharan,

This patch looks ok.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 19.09.19, 11:17, "Minios-devel on behalf of Sharan Santhanam" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
Sharan.Santhanam@xxxxxxxxx> wrote:

    syncconfig rule generate the config header file and other header files
    needed from fixdep. This patch provides a python interface for the
    syncconfig using scriptsyncconfig rule
    
    Signed-off-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
    ---
     Makefile | 10 +++++++++-
     1 file changed, 9 insertions(+), 1 deletion(-)
    
    diff --git a/Makefile b/Makefile
    index 4e873f1..2bcdc32 100644
    --- a/Makefile
    +++ b/Makefile
    @@ -676,7 +676,8 @@ COMMON_CONFIG_ENV = \
        KCONFIG_PLAT_IN="$(KCONFIG_PLAT_IN)" \
        UK_NAME="$(CONFIG_UK_NAME)"
     
    -PHONY += scriptconfig iscriptconfig kmenuconfig guiconfig dumpvarsconfig
    +PHONY += scriptconfig scriptsyncconfig iscriptconfig kmenuconfig guiconfig 
\
    +            dumpvarsconfig
     
     PYTHONCMD ?= python
     kpython := PYTHONPATH=$(UK_CONFIGLIB):$$PYTHONPATH $(PYTHONCMD)
    @@ -701,6 +702,12 @@ kmenuconfig:$(KCONFIG_DIR)/fixdep
                $(CONFIG_CONFIG_IN)
        @$(SCRIPTS_DIR)/configupdate $(UK_CONFIG) $(UK_CONFIG_OUT)
     
    +scriptsyncconfig: $(KCONFIG_DIR)/fixdep
    +   @$(COMMON_CONFIG_ENV) $(kpython) $(CONFIGLIB)/genconfig.py \
    +           --sync-deps=$(BUILD_DIR)/include/config \
    +           --header-path=$(KCONFIG_AUTOHEADER) $(CONFIG_CONFIG_IN)
    +   @$(SCRIPTS_DIR)/configupdate $(UK_CONFIG) $(UK_CONFIG_OUT)
    +
     guiconfig: $(KCONFIG_DIR)/fixdep
        @$(COMMON_CONFIG_ENV) $(kpython) $(CONFIGLIB)/guiconfig.py 
$(CONFIG_CONFIG_IN)
        @$(SCRIPTS_DIR)/configupdate $(UK_CONFIG) $(UK_CONFIG_OUT)
    @@ -884,6 +891,7 @@ help:
        @echo '  gconfig                - interactive GTK-based configurator'
        @echo '  oldconfig              - resolve any unresolved symbols in 
.config'
        @echo '  syncconfig             - Same as oldconfig, but quietly, 
additionally update deps'
    +   @echo '  scriptsyncconfig       - Same as oldconfig, but quietly, 
additionally update deps'
        @echo '  olddefconfig           - Same as silentoldconfig but sets new 
symbols to their default value'
        @echo '  randconfig             - New config with random answer to all 
options'
        @echo '  defconfig              - New config with default answer to all 
options'
    -- 
    2.7.4
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel