Re: [Minios-devel] [UNIKRAFT PATCH v3 1/2] lib/ukmmap: Introduce mmap and related functions library skeleton

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Charlampos,

I notice that this new internal library sets a dependency to newlib, and 
external library. We have a policy to have the Unikraft repo to be 
self-contained, i.e., no external dependencies. This means building against 
noblic, which I guess in your case would break because it's missing things like 
sys/mmap.h. Having said that, would you mind adding this to noblic so that we 
can remove the dependency on newlib?

Thanks,

-- Felipe

On 20.09.19, 10:38, "Minios-devel on behalf of Charalampos Mainas" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
Charalampos.Mainas@xxxxxxxxx> wrote:

    Signed-off-by: Charalampos Mainas <Charalampos.Mainas@xxxxxxxxx>
    ---
     lib/Makefile.uk          | 1 +
     lib/ukmmap/Config.uk     | 5 +++++
     lib/ukmmap/Makefile.uk   | 1 +
     lib/ukmmap/exportsyms.uk | 1 +
     4 files changed, 8 insertions(+)
     create mode 100644 lib/ukmmap/Config.uk
     create mode 100644 lib/ukmmap/Makefile.uk
     create mode 100644 lib/ukmmap/exportsyms.uk
    
    diff --git a/lib/Makefile.uk b/lib/Makefile.uk
    index a1697198..2ca9973f 100644
    --- a/lib/Makefile.uk
    +++ b/lib/Makefile.uk
    @@ -31,3 +31,4 @@ $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/uk9p))
     $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/posix-libdl))
     $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/uklibparam))
     $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/uktime))
    +$(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/ukmmap))
    diff --git a/lib/ukmmap/Config.uk b/lib/ukmmap/Config.uk
    new file mode 100644
    index 00000000..f752da85
    --- /dev/null
    +++ b/lib/ukmmap/Config.uk
    @@ -0,0 +1,5 @@
    +config LIBUKMMAP
    +   bool "ukmmap: mmap system call"
    +   default n
    +   select LIBUKALLOC
    +   select LIBNEWLIBC
    diff --git a/lib/ukmmap/Makefile.uk b/lib/ukmmap/Makefile.uk
    new file mode 100644
    index 00000000..8ac3ab3c
    --- /dev/null
    +++ b/lib/ukmmap/Makefile.uk
    @@ -0,0 +1 @@
    +$(eval $(call addlib_s,libukmmap,$(CONFIG_LIBUKMMAP)))
    diff --git a/lib/ukmmap/exportsyms.uk b/lib/ukmmap/exportsyms.uk
    new file mode 100644
    index 00000000..621e94f0
    --- /dev/null
    +++ b/lib/ukmmap/exportsyms.uk
    @@ -0,0 +1 @@
    +none
    -- 
    2.17.1
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel