Re: [Minios-devel] [UNIKRAFT PATCH] lib/devfs: Fix initcall registration

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

On 10/1/19 2:09 PM, Simon Kuenzer wrote:
> It seems that there is a typo in `device.h`: `devfs_initcall()`. Any
> device node registration to devfs using this macro would not been
> registered properly. This patch fixes the macro.
>
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
>   lib/devfs/include/devfs/device.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/devfs/include/devfs/device.h b/lib/devfs/include/devfs/device.h
> index 46a6a85a..cec71849 100644
> --- a/lib/devfs/include/devfs/device.h
> +++ b/lib/devfs/include/devfs/device.h
> @@ -215,6 +215,6 @@ void read_partition_table(struct device *device);
>    * To be on the safe side, we do the registration to devfs before both,
>    * at priority '3'.
>    */
> -#define devfs_initcall(fn) uk_rootfs_initcall_prio(devfs_automount, 3)
> +#define devfs_initcall(fn) uk_rootfs_initcall_prio(fn, 3)
>   
>   #endif /* !_DEVICE_H */
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel