[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT/LIBMICROPYTHON PATCH 1/5] Introduce library skeleton



Hi Vlad,

On 04.10.19, 13:52, "Minios-devel on behalf of Vlad-Andrei BĂDOIU (78692)" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
vlad_andrei.badoiu@xxxxxxxxxxxxxxx> wrote:

    Hey Felipe,
    
    Please see one small comment inline.
    Thanks,
    
    Vlad
    
    On 25.09.2019 11:07, Felipe Huici wrote:
    
    
    We use the BSD-3-Clause license for this library glue code.
    
    Signed-off-by: Felipe Huici <felipe.huici@xxxxxxxxx> 
<mailto:felipe.huici@xxxxxxxxx>
    ---
     CODING_STYLE.md |  4 ++++
     CONTRIBUTING.md |  4 ++++
     COPYING.md      | 39 +++++++++++++++++++++++++++++++++++++++
     Config.uk       |  8 ++++++++
     MAINTAINERS.md  | 12 ++++++++++++
     README.md       | 16 ++++++++++++++++
     exportsyms.uk   |  1 +
     7 files changed, 84 insertions(+)
     create mode 100644 CODING_STYLE.md
     create mode 100644 CONTRIBUTING.md
     create mode 100644 COPYING.md
     create mode 100644 Config.uk
     create mode 100644 MAINTAINERS.md
     create mode 100644 README.md
     create mode 100644 exportsyms.uk
    
    diff --git a/CODING_STYLE.md b/CODING_STYLE.md
    new file mode 100644
    index 0000000..5730041
    --- /dev/null
    +++ b/CODING_STYLE.md
    @@ -0,0 +1,4 @@
    +Coding Style
    +============
    +
    +Please refer to the `CODING_STYLE.md` file in the main Unikraft repository.
    diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
    new file mode 100644
    index 0000000..14f6ac6
    --- /dev/null
    +++ b/CONTRIBUTING.md
    @@ -0,0 +1,4 @@
    +Contributing to Unikraft
    +========================
    +
    +Please refer to the `CONTRIBUTING.md` file in the main Unikraft repository.
    diff --git a/COPYING.md b/COPYING.md
    new file mode 100644
    index 0000000..0664989
    --- /dev/null
    +++ b/COPYING.md
    @@ -0,0 +1,39 @@
    +License
    +=======
    +
    +Unikraft micropython wrappers
    +----------------------------------
    +
    +This repository contains wrapper code to build micropython with Unikraft.
    +Each C code file in this repository should declare who is the
    +copyright owner and under which terms and conditions the code is
    +licensed. If such a licence note is missing, the following copyright
    +notice will apply:
    +
    +   Copyright (c) Year, Institution. All rights reserved.
    
    I think that there here should be the NEC copyright.

Actually we made a decision to leave it as it is to make it more generic, there 
was a previous discussion about this on the mailing list a while back.
    
    +
    +   Redistribution and use in source and binary forms, with or without
    +   modification, are permitted provided that the following conditions
    +   are met:
    +
    +   1. Redistributions of source code must retain the above copyright
    +      notice, this list of conditions and the following disclaimer.
    +   2. Redistributions in binary form must reproduce the above copyright
    +      notice, this list of conditions and the following disclaimer in the
    +      documentation and/or other materials provided with the distribution.
    +   3. Neither the name of the copyright holder nor the names of its
    +      contributors may be used to endorse or promote products derived from
    +      this software without specific prior written permission.
    +
    +   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
IS"
    +   AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 
THE
    +   IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
PURPOSE
    +   ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS 
BE
    +   LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
    +   CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
    +   SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
    +   INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
    +   CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
    +   ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
THE
    +   POSSIBILITY OF SUCH DAMAGE.
    +
    diff --git a/Config.uk b/Config.uk
    new file mode 100644
    index 0000000..b38a7d7
    --- /dev/null
    +++ b/Config.uk
    @@ -0,0 +1,8 @@
    +config LIBMICROPYTHON
    +      bool "Micropython - Python for microcontrollers"
    +      default y
    +      select LIBLWIP
    +      select LIBNEWLIBC
    +      select LWIP_NOTHREADS
    +      select LWIP_IGMP
    +      select LIBUKMMAP
    \ No newline at end of file
    diff --git a/MAINTAINERS.md b/MAINTAINERS.md
    new file mode 100644
    index 0000000..ca50121
    --- /dev/null
    +++ b/MAINTAINERS.md
    @@ -0,0 +1,12 @@
    +Maintainers List
    +================
    +
    +For notes on how to read this information, please refer to 
`MAINTAINERS.md` in
    +the main Unikraft repository.
    +
    +   LIBPCRE-UNIKRAFT
    +   M: Felipe Huici <felipe.huici@xxxxxxxxx> <mailto:felipe.huici@xxxxxxxxx>
    +   M: Simon Kuenzer <simon.kuenzer@xxxxxxxxx> 
<mailto:simon.kuenzer@xxxxxxxxx>
    +   M: Vlad-Andrei BĂDOIU <vlad_andrei.badoiu@xxxxxxxxxxxxxxx> 
<mailto:vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
    +   L: minios-devel@xxxxxxxxxxxxx
    +   F: *
    diff --git a/README.md b/README.md
    new file mode 100644
    index 0000000..8fa3b85
    --- /dev/null
    +++ b/README.md
    @@ -0,0 +1,16 @@
    +micorpython for Unikraft
    +=============================
    +
    +This is the port of micropython for Unikraft as external library. By
    +default, when running the port will go into interactive mode (though
    +note that for now there is a slight problem with it in that characters
    +are echoed twice). Alternatively, you can run a script from a file if
    +passed as a initrd parameter.
    +
    +Please also note that in the menu, for lwip, you need to select the
    +"Mainloop (non-threaded)" option for "Operation mode". This is stated
    +in Micropython's Config.uk (select LWIP_NOTHREADS), but this feature
    +is broken in kConfig.
    +
    +Please refer to the `README.md` as well as the documentation in the `doc/`
    +subdirectory of the main unikraft repository.
    diff --git a/exportsyms.uk b/exportsyms.uk
    new file mode 100644
    index 0000000..c86c3f3
    --- /dev/null
    +++ b/exportsyms.uk
    @@ -0,0 +1 @@
    +none
    \ No newline at end of file
    
    _______________________________________________
    Minios-devel mailing list
    
Minios-devel@lists.xenproject.orghttps://lists.xenproject.org/mailman/listinfo/minios-devel
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.