Re: [Minios-devel] [UNIKRAFT PATCH] lib/uknetdev: Select virtio driver on KVM when enabling library

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Hey,

I agree that the current state with selecting the network driver 
explicitly is not nice and fixing this makes totally sense. However, 
can't we solve this change the opposite way round, from within the KVM 
platform?:
```
config VIRTIO_NET
       bool "Virtio Net device"
       default y if LIBUKNETDEV
       default n
       depends on LIBUKNETDEV
       select VIRTIO_BUS
       select LIBUKSGLIST
       help
              Virtual network driver.
```

I am concerned that putting platform library details into the general 
purpose libraries is bound to get inconsistent/incomplete. For instance, 
how would you handle this with external platforms?
Thanks,

Simon


On 09.10.19 10:17, Roxana Nicolescu wrote:
> Thanks, Costin!
>
> Reviewed-by: Roxana Nicolescu <nicolescu.roxana1996@xxxxxxxxx>
>
> On 04.10.2019 19:34, Costin Lupu wrote:
> > Using the uknetdev library alone does not make much sense without a 
> > network
> > driver. Moreover, it's cleaner to tick network support just once and all
> > underlying dependencies to be enabled. We reached these conclusions at 
> > several
> > Unikraft hackathons we did so far.
> >
> > Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> > ---
> >   lib/uknetdev/Config.uk | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/uknetdev/Config.uk b/lib/uknetdev/Config.uk
> > index 618e8e67..2de7aca0 100644
> > --- a/lib/uknetdev/Config.uk
> > +++ b/lib/uknetdev/Config.uk
> > @@ -4,6 +4,7 @@ menuconfig LIBUKNETDEV
> >       select LIBNOLIBC if !HAVE_LIBC
> >       select LIBUKDEBUG
> >       select LIBUKALLOC
> > +    select VIRTIO_NET if PLAT_KVM >>   if LIBUKNETDEV
> >       config LIBUKNETDEV_MAXNBQUEUES
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel