Re: [Minios-devel] [UNIKRAFT/LIBUUID PATCH] Add PRECIOUS target to Makefile.uk, select deps in Config.uk.

[Costin Lupu <costin.lup@xxxxxxxxx>]

Thanks for this patch, Felipe! I tested it with Python 3.

Reviewed-by: Costin Lupu <costin.lupu@xxxxxxxxx>

On 10/8/19 4:52 PM, Felipe Huici wrote:
> This patch adds a target to Makefile.uk so that public headers are not
> deleted after the build. It also modifies Config.uk to explicitly
> select all deps needed by libuuid.
> 
> Signed-off-by: Felipe Huici <felipe.huici@xxxxxxxxx>
> ---
>  Config.uk   | 3 ++-
>  Makefile.uk | 2 ++
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Config.uk b/Config.uk
> index eac7ef5..7331305 100644
> --- a/Config.uk
> +++ b/Config.uk
> @@ -1,5 +1,6 @@
>  config LIBUUID
>       bool "libuuid - library for unique id generation"
>       default n
> -     depends on HAVE_LIBC
> +     select LIBNEWLIBC
>       select UKUNISTD
> +     select LIBUKTIME
> \ No newline at end of file
> diff --git a/Makefile.uk b/Makefile.uk
> index f18fb19..b093f64 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -99,6 +99,8 @@ LIBUUID_SRCS-y += $(LIBUUID_SRC)/uuid_time.c
>  
> ################################################################################
>  # Lib-specific Targets
>  
> ################################################################################
> +.PRECIOUS: $(LIBUUID_EXTRACTED)/%.h
> +
>  $(LIBUUID_BUILD)/include/public/%.h: $(LIBUUID_SRC)/%.h
>       $(call build_cmd,LN,libuuid,$@,\
>       ln -sf $< $@)
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel