Hi Justin,
On 11.10.19, 09:31, "Minios-devel on behalf of Jia He"
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of jiakernel2@xxxxxxxxx> wrote:
Hi Felipe
On 2019/10/8 21:15, Felipe Huici wrote:
> Add bh_platform.h which was auto-generated from a local build.
>
> Signed-off-by: Felipe Huici <felipe.huici@xxxxxxxxx>
> ---
> include/bh_platform.h | 129 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 129 insertions(+)
> create mode 100644 include/bh_platform.h
>
> diff --git a/include/bh_platform.h b/include/bh_platform.h
> new file mode 100644
> index 0000000..00c25b4
> --- /dev/null
> +++ b/include/bh_platform.h
> @@ -0,0 +1,129 @@
> +/*
> + * Copyright (C) 2019 Intel Corporation. All rights reserved.
> + *
> + * Licensed under the Apache License, Version 2.0 (the "License");
> + * you may not use this file except in compliance with the License.
> + * You may obtain a copy of the License at
> + *
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +
> +#ifndef _BH_PLATFORM_H
> +#define _BH_PLATFORM_H
> +
> +#include "bh_config.h"
> +#include "bh_types.h"
> +#include "bh_memory.h"
> +#include <inttypes.h>
> +#include <stdbool.h>
> +#include <assert.h>
> +#include <time.h>
> +#include <string.h>
> +#include <stdio.h>
> +#include <assert.h>
Could we remove the redundant including ?
Yes, definiitely. Again, maybe we can do it on upstreaming?
