[Minios-devel] [UNIKRAFT PATCH 0/3] Make changes for fixing compilation warnings with

[Costin Lupu <costin.lupu@xxxxxxxxx>]

Many times, the compilation warnings indicate some more important issues which
require solutions that are not trivial. This is one of those situations.

uktime internal lib defines the timegm() function which is needed by Python 3.
Although the build was successful, we did encounter a compilation warning
because the compiler did not find the function declaration which is in the
<time.h> header of uktime library. This happened because (1) the headers of
external libraries are included before those of internal libraries and (2)
newlib provides its own <time.h> header which doesn't declare timegm() (of
course).

Therefore the solution is to include internal lib headers first because they
provide the fundamental type definitions (just as uktime does for time related
types). This is not enough though - newlib also defines some stuff of its own
which has to be integrated with our definitions and for this we do a bit of
refactoring in uktime. The last patch fixes the warnings happening for some
user related missing functions declarations.

Costin Lupu (3):
  Makefile: Include internal libs Makefile.uk before external libs
    Makefile.uk
  lib/uktime: Introduce time_types.h for type defintions
  lib/ukunistd: Add user.h for user related functions declarations

 Makefile                                      |  3 +-
 .../include/nolibc-internal/shareddefs.h      | 41 +---------
 lib/uktime/include/uk/time_types.h            | 74 +++++++++++++++++++
 lib/uktime/musl-imported/include/sys/time.h   | 10 ++-
 lib/uktime/musl-imported/include/time.h       |  7 ++
 lib/ukunistd/Makefile.uk                      |  2 +
 lib/ukunistd/include/uk/user.h                | 54 ++++++++++++++
 lib/ukunistd/user.c                           |  1 +
 plat/xen/x86/arch_time.c                      |  2 +-
 9 files changed, 150 insertions(+), 44 deletions(-)
 create mode 100644 lib/uktime/include/uk/time_types.h
 create mode 100644 lib/ukunistd/include/uk/user.h

-- 
2.20.1


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel