Re: [Minios-devel] [UNIKRAFT/GCC PATCH 2/2] Makefile.uk: Skip building types.c and closures.c with Python3

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Costin, this looks ok.  

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 13.10.19, 17:12, "Minios-devel on behalf of Costin Lupu" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of costin.lupu@xxxxxxxxx> 
wrote:

    Python3 comes with its own types and closures when enabling _ctypes 
extension.
    We currently check if the extension is enabled, but a more generic symbol 
should
    be defined at some point.
    
    Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
    ---
     Makefile.uk | 4 +++-
     1 file changed, 3 insertions(+), 1 deletion(-)
    
    diff --git a/Makefile.uk b/Makefile.uk
    index 276ab1c..d5901e2 100644
    --- a/Makefile.uk
    +++ b/Makefile.uk
    @@ -109,11 +109,13 @@ LIBFFI_CFLAGS-y += -DHAVE_CONFIG_H -fexceptions -Wall 
\
        -Wno-implicit-function-declaration -Wno-sign-compare \
        -Wno-unused-parameter -Wno-empty-body -Wno-implicit-fallthrough
     
    +ifneq ($(CONFIG_LIBPYTHON3_EXTENSION_CTYPES),y)
    +LIBFFI_SRCS-y += $(LIBFFI_EXTRACTED)/src/types.c
     LIBFFI_SRCS-y += $(LIBFFI_EXTRACTED)/src/closures.c
    +endif
     LIBFFI_SRCS-y += $(LIBFFI_EXTRACTED)/src/java_raw_api.c
     LIBFFI_SRCS-y += $(LIBFFI_EXTRACTED)/src/prep_cif.c
     LIBFFI_SRCS-y += $(LIBFFI_EXTRACTED)/src/raw_api.c
    -LIBFFI_SRCS-y += $(LIBFFI_EXTRACTED)/src/types.c
     LIBFFI_SRCS-$(CONFIG_ARCH_X86_64) += $(LIBFFI_EXTRACTED)/src/x86/ffi64.c
     LIBFFI_SRCS-$(CONFIG_ARCH_X86_64) += $(LIBFFI_EXTRACTED)/src/x86/unix64.S
     
    -- 
    2.20.1
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel