Re: [Minios-devel] [UNIKRAFT/MUSL PATCH 01/19] Add support for C++ applications

[Costin Lupu <costin.lup@xxxxxxxxx>]

Hi Gaulthier,

You should refactor a bit and use some auxiliary variable in order to
avoid duplicated code. E.g.:

LIBMUSL_GLOBAL_INCLUDES-y += -I$(LIBMUSL_BASE)/include
...

CINCLUDES-y    += $(LIBMUSL_GLOBAL_INCLUDES-y)
CXXINCLUDES-y  += $(LIBMUSL_GLOBAL_INCLUDES-y)

Btw, $(CONFIG_LIBMUSL) is a bit redundant. $(CONFIG_LIBMUSL) is already
y, of course. You should use that approach for other variables, e.g.
variables representing features:

LIBMUSL_GLOBAL_INCLUDES-$(CONFIG_LIBMUSL_PTHREAD) +=
-I$(LIBMUSL_BASE)/include/pthread

Cheers,
Costin

On 10/15/19 6:23 PM, Gaulthier Gain wrote:
> Update Makefile.uk to provide support to C++ applications.
> 
> Signed-off-by: Gaulthier Gain <gaulthier.gain@xxxxxxxxx>
> ---
>  Makefile.uk | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Makefile.uk b/Makefile.uk
> index fc31a72..98c40aa 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -63,6 +63,14 @@ CINCLUDES-$(CONFIG_LIBMUSL)   += -I$(LIBMUSL)/src/internal
>  CINCLUDES-$(CONFIG_LIBMUSL)   += -I$(LIBMUSL)/src/ctype
>  CINCLUDES-$(CONFIG_LIBMUSL)   += -I$(LIBMUSL)/src/dirent
>  
> +CXXINCLUDES-$(CONFIG_LIBMUSL) += -I$(LIBMUSL_BASE)/include
> +CXXINCLUDES-$(CONFIG_LIBMUSL) += -I$(LIBMUSL)/include
> +CXXINCLUDES-$(CONFIG_LIBMUSL) += -I$(LIBMUSL)/arch/$(ARCH)
> +CXXINCLUDES-$(CONFIG_LIBMUSL) += -I$(LIBMUSL)/arch/generic
> +CXXINCLUDES-$(CONFIG_LIBMUSL) += -I$(LIBMUSL)/src/internal
> +CXXINCLUDES-$(CONFIG_LIBMUSL) += -I$(LIBMUSL)/src/ctype
> +CXXINCLUDES-$(CONFIG_LIBMUSL) += -I$(LIBMUSL)/src/dirent
> +
>  
> ################################################################################
>  # Musl-specific Targets
>  
> ################################################################################
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel