Re: [Minios-devel] [UNIKRAFT/PTHREAD-EMBEDDED PATCH] Add pthread_sigmask() stub

[Stefan Teodorescu <stefanl.teodorescu@xxxxxxxxx>]

Okay for now, but we should see whether returning 0 (success) is the
intended behavior.
Some apps may call this method and actually expect it to work, so this
might affect their functionality.

Reviewed-by: Stefan Teodorescu <stefanl.teodorescu@xxxxxxxxx>

On Fri, Nov 1, 2019 at 1:20 PM Costin Lupu <costin.lupu@xxxxxxxxx> wrote:
>
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> ---
>  Makefile.uk       |  1 +
>  exportsyms.uk     |  1 +
>  pthread_sigmask.c | 29 +++++++++++++++++++++++++++++
>  3 files changed, 31 insertions(+)
>  create mode 100644 pthread_sigmask.c
>
> diff --git a/Makefile.uk b/Makefile.uk
> index 5a6d940..90626e8 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -67,6 +67,7 @@ LIBPTHREAD-EMBEDDED_EXPORTS = 
> $(LIBPTHREAD-EMBEDDED_BASE)/exportsyms.uk
>  LIBPTHREAD-EMBEDDED_SRCS-y += $(LIBPTHREAD-EMBEDDED_BASE)/pte_osal.c|glue
>  LIBPTHREAD-EMBEDDED_SRCS-y += $(LIBPTHREAD-EMBEDDED_BASE)/attributes.c|glue
>  LIBPTHREAD-EMBEDDED_SRCS-y += 
> $(LIBPTHREAD-EMBEDDED_BASE)/pthread_atfork.c|glue
> +LIBPTHREAD-EMBEDDED_SRCS-y += 
> $(LIBPTHREAD-EMBEDDED_BASE)/pthread_sigmask.c|glue
>
>  
> ################################################################################
>  # pthread-embedded code
> diff --git a/exportsyms.uk b/exportsyms.uk
> index c69aae3..63d1f85 100644
> --- a/exportsyms.uk
> +++ b/exportsyms.uk
> @@ -80,6 +80,7 @@ pthread_setcanceltype
>  pthread_setconcurrency
>  pthread_setschedparam
>  pthread_setspecific
> +pthread_sigmask
>  pthread_spin_destroy
>  pthread_spin_init
>  pthread_spin_lock
> diff --git a/pthread_sigmask.c b/pthread_sigmask.c
> new file mode 100644
> index 0000000..7e12e2b
> --- /dev/null
> +++ b/pthread_sigmask.c
> @@ -0,0 +1,29 @@
> +/* SPDX-License-Identifier: LGPL-2.0-or-later */
> +/*
> + *      Unikraft port of POSIX Threads Library for embedded systems
> + *      Copyright(C) 2019 Costin Lupu, University Politehnica of Bucharest
> + *
> + *      This library is free software; you can redistribute it and/or
> + *      modify it under the terms of the GNU Lesser General Public
> + *      License as published by the Free Software Foundation; either
> + *      version 2 of the License, or (at your option) any later version.
> + *
> + *      This library is distributed in the hope that it will be useful,
> + *      but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *      MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + *      Lesser General Public License for more details.
> + *
> + *      You should have received a copy of the GNU Lesser General Public
> + *      License along with this library in the file COPYING.LIB;
> + *      if not, write to the Free Software Foundation, Inc.,
> + *      59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
> + */
> +
> +#include <uk/print.h>
> +#include <signal.h>
> +
> +int pthread_sigmask(int how, const sigset_t *set, sigset_t *oldset)
> +{
> +       WARN_STUBBED();
> +       return 0;
> +}
> --
> 2.20.1
>
>
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel