Re: [Minios-devel] [UNIKRAFT/REDIS PATCH 2/4] Build Redis server as library

[Costin Lupu <costin.lup@xxxxxxxxx>]

On 11/14/19 10:12 AM, Simon Kuenzer wrote:
> On 10.11.19 15:47, Costin Lupu wrote:
>> Signed-off-by: Bogdan Lascu <lascu.bogdan96@xxxxxxxxx>
>> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
>> ---
>>   Config.uk                                     |  19 +-
>>   Makefile.uk                                   | 199 ++++++++++++++++++
>>   ...se-linux-macros-for-Unikraft-as-well.patch |  26 +++
>>   3 files changed, 242 insertions(+), 2 deletions(-)
>>   create mode 100644 Makefile.uk
>>   create mode 100644
>> patches/0001-hiredis-Use-linux-macros-for-Unikraft-as-well.patch
>>
>> diff --git a/Config.uk b/Config.uk
>> index dea2ebf..1dd4f9d 100644
>> --- a/Config.uk
>> +++ b/Config.uk
>> @@ -1,7 +1,22 @@
>> -config LIBREDIS
>> +menuconfig LIBREDIS
>>       bool "Redis"
>>       default n
>> -    select LIBNOLIBC if !HAVE_LIBC
>>       select LIBUKDEBUG
>>       select LIBUKALLOC
>>       select LIBUKSCHED
>> +    select LIBNEWLIBC
>> +    select LIBNEWLIBC_WANT_IO_C99_FORMATS if LIBNEWLIBC
>> +    select LIBNEWLIBC_LINUX_ERRNO_EXTENSIONS if LIBNEWLIBC
>> +    select LIBPTHREAD_EMBEDDED
>> +    select UKSYSINFO
>> +    select LIBPOSIX_LIBDL
>> +    select LIBLWIP
>> +    select LWIP_IPV6
> 
> Out of curiosity: Is IPv6 a hard requirement or would an 'imply' also
> work fine? I am asking this just as side node. As initial port of reddis
> this is totally fine.

Hi Simon,

It doesn't build without IPv6. Some of the IPv6 related code is in
build/libredis/origin/redis-5.0.6/src/anet.c.

Cheers,
Costin

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel