Re: [Minios-devel] [UNIKRAFT/REDIS PATCH v2 2/4] Build Redis server and client as libraries

[Costin Lupu <costin.lup@xxxxxxxxx>]

On 11/17/19 1:54 PM, Stefan Teodorescu wrote:
> The client and the server work. As discussed, there should also be a
> README that covers some problems (like adding loopback if needed to
> connect on localhost, or sending parameters to the client to add a
> config file etc.).
> 
> There is also a problem with the client's IO, when typing in QEMU,
> weird tabs and newlines get inserted, but this can be fixed later.
> 
> Reviewed-by: Stefan Teodorescu <stefanl.teodorescu@xxxxxxxxx>

Thanks for the reviews and feedback, Ștefan!

In deed, CLI has some issues that should be addressed in a different
patch. I'll send the patch for the README a bit later.

Cheers,
Costin

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel