Re: [Minios-devel] [UNIKRAFT/PROTOBUF PATCH 1/4] Introduce library skeleton

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Vlad, you have a copy and paste error ("benchmark") but I see you fix this 
in patch 2 of this series, so

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 31.10.19, 00:36, "Vlad-Andrei BĂDOIU (78692)" 
<vlad_andrei.badoiu@xxxxxxxxxxxxxxx> wrote:

    We use the BSD-3-Clause license for this library glue code. Currently,
    only C++ is supported.

    
    Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
    ---
     .gitignore      | 27 +++++++++++++++++++++++++++
     CODING_STYLE.md |  4 ++++
     CONTRIBUTING.md |  4 ++++
     COPYING.md      | 30 ++++++++++++++++++++++++++++++
     Config.uk       | 10 ++++++++++
     MAINTAINERS.md  | 11 +++++++++++
     README.md       | 13 +++++++++++++
     7 files changed, 99 insertions(+)
     create mode 100644 .gitignore
     create mode 100644 CODING_STYLE.md
     create mode 100644 CONTRIBUTING.md
     create mode 100644 COPYING.md
     create mode 100644 Config.uk
     create mode 100644 MAINTAINERS.md
     create mode 100644 README.md
    
    diff --git a/.gitignore b/.gitignore
    new file mode 100644
    index 0000000..75d2fd3
    --- /dev/null
    +++ b/.gitignore
    @@ -0,0 +1,27 @@
    +*.depend
    +*.o
    +*.a
    +*.d
    +*.so
    +*.orig
    +*.rej
    +*.bak
    +*.swp
    +*~
    +,*
    +\#*\#
    +.\#*
    +\#_*\#
    +.\#_*
    +!.gitignore
    +.*
    +
    +# gnu global files
    +GPATH
    +GRTAGS
    +GSYMS
    +GTAGS
    +
    +# cscope files
    +cscope.*
    +ncscope.*
    diff --git a/CODING_STYLE.md b/CODING_STYLE.md
    new file mode 100644
    index 0000000..5730041
    --- /dev/null
    +++ b/CODING_STYLE.md
    @@ -0,0 +1,4 @@
    +Coding Style
    +============
    +
    +Please refer to the `CODING_STYLE.md` file in the main Unikraft repository.
    diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
    new file mode 100644
    index 0000000..5f55eca
    --- /dev/null
    +++ b/CONTRIBUTING.md
    @@ -0,0 +1,4 @@
    +Contributing to Unikraft
    +=======================
    +
    +Please refer to the `CONTRIBUTING.md` file in the main Unikraft repository.
    diff --git a/COPYING.md b/COPYING.md
    new file mode 100644
    index 0000000..adceb01
    --- /dev/null
    +++ b/COPYING.md
    @@ -0,0 +1,30 @@
    +License
    +=======
    +
    +Unikraft protobuf wrapper
    +-----------------------
    +
    +This repository contains wrapper code to build protobuf with Unikraft.
    +Each C code file in this repository should declare who is the
    +copyright owner and under which terms and conditions the code is
    +licensed. If such a licence note is missing, the following copyright
    +notice will apply:
    +
    +   Copyright (c) 2019, University Politehnica of Bucharest. All rights 
    +   reserved.
    +
    +   This library is free software; you can redistribute it and/or
    +   modify it under the terms of the GNU Lesser General Public
    +   License as published by the Free Software Foundation; either
    +   version 2 of the License, or (at your option) any later version.
    +   
    +   This library is distributed in the hope that it will be useful,
    +   but WITHOUT ANY WARRANTY; without even the implied warranty of
    +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
    +   Lesser General Public License for more details.
    +   
    +   You should have received a copy of the GNU Lesser General Public
    +   License along with this library in the file COPYING.LIB;
    +   if not, write to the Free Software Foundation, Inc.,
    +   59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
    +
    diff --git a/Config.uk b/Config.uk
    new file mode 100644
    index 0000000..7b8f0f1
    --- /dev/null
    +++ b/Config.uk
    @@ -0,0 +1,10 @@
    +menuconfig LIBPROTOBUF
    +    bool "Protobuf"
    +    select UKSYSINFO
    +    select LIBCXX
    +    select LIBCOMPILER_RT_ATOMIC
    +    select LIBPTHREAD_EMBEDDED
    +    select UKUNISTD
    +    select LIBUKTIME
    +    select LIBNEWLIBC
    +    default n
    diff --git a/MAINTAINERS.md b/MAINTAINERS.md
    new file mode 100644
    index 0000000..911573c
    --- /dev/null
    +++ b/MAINTAINERS.md
    @@ -0,0 +1,11 @@
    +Maintainers List
    +================
    +
    +For notes on how to read this information, please refer to 
`MAINTAINERS.md` in
    +the main Unikraft repository.
    +
    +   PROTOBUF-UNIKRAFT
    +   M:      Felipe Huici <felipe.huici@xxxxxxxxx>
    +   M:      Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
    +   L:      minios-devel@xxxxxxxxxxxxx
    +   F: *
    diff --git a/README.md b/README.md
    new file mode 100644
    index 0000000..0605ff4
    --- /dev/null
    +++ b/README.md
    @@ -0,0 +1,13 @@
    +benchmark for Unikraft
    +===================

> You have a copy & paste error here (benchmark), though I see you fix this in 
> patch #2 of the series :).

    +
    +This is the port of benchmark for Unikraft as external library.

> Ditto

    +
    +## Build
    +Benchmark depends on the following libraries, that need to be added to 
`Makefile` in this order:
    +* `pthreads`, e.g. `pthread-embedded`

> Ditto

    +* CXX standard library, e.g. `libunwind`, `compiler-rt`, `libcxxabi`, 
`libcxx`
    +* `libc`, e.g. `newlib`
    +
    +Please refer to the `README.md` as well as the documentation in the `doc/`
    +subdirectory of the main unikraft repository.
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel