[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT/SQLITE PATCH V2 1/3] Introduce library skeleton



Hi Gaulthier,

Thanks for this series! SQLite will be a nice addition to Unikraft. Please see 
comments inline.

-- Felipe

On 20.11.19, 15:21, "Minios-devel on behalf of Gaulthier Gain" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
gaulthier.gain@xxxxxxxxx> wrote:

    We use the BSD-3 license.
    
    Signed-off-by: Gaulthier Gain <gaulthier.gain@xxxxxxxxx>
    ---
     .gitignore      |  3 +++
     CODING_STYLE.md |  4 ++++
     CONTRIBUTING.md |  4 ++++
     COPYING.md      | 39 +++++++++++++++++++++++++++++++++++++++
     Config.uk       |  9 +++++++++
     MAINTAINERS.md  | 11 +++++++++++
     README.md       |  7 +++++++
     7 files changed, 77 insertions(+)
     create mode 100644 .gitignore
     create mode 100644 CODING_STYLE.md
     create mode 100644 CONTRIBUTING.md
     create mode 100644 COPYING.md
     create mode 100644 Config.uk
     create mode 100644 MAINTAINERS.md
     create mode 100644 README.md
    
    diff --git a/.gitignore b/.gitignore
    new file mode 100644
    index 0000000..503fa3b
    --- /dev/null
    +++ b/.gitignore
    @@ -0,0 +1,3 @@
    +.config
    +.config.old
    +build/

> You should probably use one of our standard .gitignore files, e.g., 
> https://github.com/unikraft/lib-python3/blob/staging/.gitignore

    diff --git a/CODING_STYLE.md b/CODING_STYLE.md
    new file mode 100644
    index 0000000..5730041
    --- /dev/null
    +++ b/CODING_STYLE.md
    @@ -0,0 +1,4 @@
    +Coding Style
    +============
    +
    +Please refer to the `CODING_STYLE.md` file in the main Unikraft repository.
    diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
    new file mode 100644
    index 0000000..14f6ac6
    --- /dev/null
    +++ b/CONTRIBUTING.md
    @@ -0,0 +1,4 @@
    +Contributing to Unikraft
    +========================
    +
    +Please refer to the `CONTRIBUTING.md` file in the main Unikraft repository.
    diff --git a/COPYING.md b/COPYING.md
    new file mode 100644
    index 0000000..4b56107
    --- /dev/null
    +++ b/COPYING.md
    @@ -0,0 +1,39 @@
    +License
    +=======
    +
    +Unikraft SQLite wrappers
    +----------------------------------
    +
    +This repository contains wrapper code to build $libname with Unikraft.

> s/$libname/SQLite

    +Each C code file in this repository should declare who is the
    +copyright owner and under which terms and conditions the code is
    +licensed. If such a licence note is missing, the following copyright
    +notice will apply:
    +
    +   Copyright (c) Year, Institution. All rights reserved.
    +
    +   Redistribution and use in source and binary forms, with or without
    +   modification, are permitted provided that the following conditions
    +   are met:
    +
    +   1. Redistributions of source code must retain the above copyright
    +      notice, this list of conditions and the following disclaimer.
    +   2. Redistributions in binary form must reproduce the above copyright
    +      notice, this list of conditions and the following disclaimer in the
    +      documentation and/or other materials provided with the distribution.
    +   3. Neither the name of the copyright holder nor the names of its
    +      contributors may be used to endorse or promote products derived from
    +      this software without specific prior written permission.
    +
    +   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
IS"
    +   AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 
THE
    +   IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
PURPOSE
    +   ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS 
BE
    +   LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
    +   CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
    +   SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
    +   INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
    +   CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
    +   ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
THE
    +   POSSIBILITY OF SUCH DAMAGE.
    +
    diff --git a/Config.uk b/Config.uk
    new file mode 100644
    index 0000000..6656275
    --- /dev/null
    +++ b/Config.uk
    @@ -0,0 +1,9 @@
    +### Invisible option for dependencies
    +config LIBSQLITE_DEPENDENCIES

> To be consistent with other libs, please s/LIBSQLITE_DEPENDENCIES/LIBSQLITE
    +    bool
> This should be 'bool "SQLite"'

    +    default y
    +    select LIBNOLIBC if !HAVE_LIBC

> SQLite doesn't build against nolibc, so it's better to remove this line.

    +    select LIBUKMMAP
    +    select UKSYSINFO
    +    select LIBNEWLIBC
    +    select LIBPTHREAD_EMBEDDED
    diff --git a/MAINTAINERS.md b/MAINTAINERS.md
    new file mode 100644
    index 0000000..7c13ed9
    --- /dev/null
    +++ b/MAINTAINERS.md
    @@ -0,0 +1,11 @@
    +Maintainers List
    +================
    +
    +For notes on how to read this information, please refer to 
`MAINTAINERS.md` in
    +the main Unikraft repository.
    +
    +   LIBSQLITE-UNIKRAFT
    +   M:  Gaulthier Gain <gaulthier.gain@xxxxxxxxx>
    +   M:  Felipe Huici <felipe.huici@xxxxxxxxx>
    +   L:  minios-devel@xxxxxxxxxxxxx
    +   F: *
    diff --git a/README.md b/README.md
    new file mode 100644
    index 0000000..95a0e34
    --- /dev/null
    +++ b/README.md
    @@ -0,0 +1,7 @@
    +SQLite for Unikraft
    +=============================
    +
    +This is the port of SQLite for Unikraft as external library.

You should list external lib deps here (newlib, pthread-embedded). See 
https://github.com/unikraft/lib-python3 under the "Build" sub-header.

    +
    +Please refer to the `README.md` as well as the documentation in the `doc/`
    +subdirectory of the main unikraft repository.
    -- 
    2.11.0
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.