Re: [Minios-devel] [UNIKRAFT/SQLITE PATCH V2 2/3] Add Makefile.uk

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Gaulthier,

Please see inline.

On 20.11.19, 15:21, "Minios-devel on behalf of Gaulthier Gain" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
gaulthier.gain@xxxxxxxxx> wrote:

    Signed-off-by: Gaulthier Gain <gaulthier.gain@xxxxxxxxx>
    ---
     Makefile.uk | 84 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
     1 file changed, 84 insertions(+)
     create mode 100644 Makefile.uk
    
    diff --git a/Makefile.uk b/Makefile.uk
    new file mode 100644
    index 0000000..efa425c
    --- /dev/null
    +++ b/Makefile.uk
    @@ -0,0 +1,84 @@
    +#  SPDX-License-Identifier: BSD-3-Clause
    +#
    +#  SQLite Makefile.uk
    +#
    +#  Authors: Gain Gaulthier <gaulthier.gain@xxxxxxxxx>
    +#
    +#  Copyright (c) 2019, University of Liege. All rights reserved.
    +#
    +#  Redistribution and use in source and binary forms, with or without
    +#  modification, are permitted provided that the following conditions
    +#  are met:
    +#
    +#  1. Redistributions of source code must retain the above copyright
    +#     notice, this list of conditions and the following disclaimer.
    +#  2. Redistributions in binary form must reproduce the above copyright
    +#     notice, this list of conditions and the following disclaimer in the
    +#     documentation and/or other materials provided with the distribution.
    +#  3. Neither the name of the copyright holder nor the names of its
    +#     contributors may be used to endorse or promote products derived from
    +#     this software without specific prior written permission.
    +#
    +#  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
IS"
    +#  AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 
THE
    +#  IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
PURPOSE
    +#  ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS 
BE
    +#  LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
    +#  CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
    +#  SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
    +#  INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
    +#  CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
    +#  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
THE
    +#  POSSIBILITY OF SUCH DAMAGE.
    +#
    +#  THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
    +#
    +
    
+################################################################################
    +# App registration
    
+################################################################################
    +$(eval $(call addlib,libsqlite))
    +
    
+################################################################################
    +# Sources
    
+################################################################################
    +LIBSQLITE_VERSION = 3300100
    +LIBSQLITE_BASENAME = sqlite-amalgamation-$(LIBSQLITE_VERSION)
    +LIBSQLITE_URL = https://www.sqlite.org/2019/$(LIBSQLITE_BASENAME).zip
    +LIBSQLITE_PATCHDIR = $(LIBSQLITE_BASE)/patches
    +$(eval $(call fetch,libsqlite,$(LIBSQLITE_URL)))
    +$(eval $(call 
patch,libsqlite,$(LIBSQLITE_PATCHDIR),sqlite-$(LIBSQLITE_VERSION)))
    +
    
+################################################################################
    +# Helpers
    
+################################################################################
    +LIBSQLITE_SRC = $(LIBSQLITE_ORIGIN)/$(LIBSQLITE_BASENAME)
    +
    
+################################################################################
    +# Library includes
    
+################################################################################
    +CINCLUDES-y += -I$(LIBSQLITE_BASE)/include

> You should namespace this (s/CINCLUDES-y/ LIBSQLITE_CINCLUDES-y)

    +LIBSQLITE_CINCLUDES += -I$(LIBSQLITE_SRC)
    +
    
+################################################################################
    +# Global flags
    
+################################################################################
    +LIBSQLITE_FLAGS = -D_HAVE_SQLITE_CONFIG_H -DSQLITE_OMIT_LOAD_EXTENSION
    +
    +# Suppress some warnings to make the build process look neater
    +SUPPRESS_FLAGS += -Wno-unused-parameter -Wno-unused-variable -Wno-nonnull  
     \
    +-Wno-unused-but-set-variable -Wno-unused-label -Wno-char-subscripts        
     \
    +-Wno-unused-function -Wno-missing-field-initializers -Wno-uninitialized    
     \
    +-Wno-array-bounds -Wno-maybe-uninitialized -Wno-pointer-sign 
-Wno-unused-value  \
    +-Wno-unused-macros -Wno-parentheses -Wno-implicit-function-declaration     
     \
    +-Wno-missing-braces -Wno-endif-labels -Wno-unused-but-set-variable         
     \
    +-Wno-implicit-function-declaration -Wno-type-limits -Wno-sign-compare

> That's a lot of suppress flags, which I suppose you probably copied and 
> pasted, and yet there are still a number of unsupressed warnings (e.g., 
> -Wimplicit-fallthrough). I was wondering whether it wouldn't be better to 
> remove this list, and then just build a list specific to this build. Also, 
> please namespace the SUPPRESS_FLAGS variable name.

    +LIBSQLITE_CFLAGS-y += $(LIBSQLITE_FLAGS)
    +LIBSQLITE_CFLAGS-y += $(SUPPRESS_FLAGS)
    +
    
+################################################################################
    +# SQLite sources
    
+################################################################################
    +LIBSQLITE_SRCS-y += $(LIBSQLITE_SRC)/shell.c
    +LIBSQLITE_SRCS-y += $(LIBSQLITE_SRC)/sqlite3.c

> It might be a good idea to add an optional main() to the build. See 
> https://github.com/unikraft/lib-lua/blob/staging/main.c, 
> https://github.com/unikraft/lib-lua/blob/staging/Config.uk , and 
> https://github.com/unikraft/lib-lua/blob/staging/Makefile.uk (lines 37 and 
> 52).

    -- 
    2.11.0
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel