Re: [Minios-devel] [UNIKRAFT PATCH 1/2] lib/ukmmap: Add stub for mremap

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Vlad, this patch looks fine.

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 19.11.19, 00:58, "Vlad-Andrei BĂDOIU (78692)" 
<vlad_andrei.badoiu@xxxxxxxxxxxxxxx> wrote:

    The stub returns -1 in order to avoid bad memory accesses by the calling
    function.
    
    Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
    ---
     lib/ukmmap/exportsyms.uk | 1 +
     lib/ukmmap/mmap.c        | 6 ++++++
     2 files changed, 7 insertions(+)
    
    diff --git a/lib/ukmmap/exportsyms.uk b/lib/ukmmap/exportsyms.uk
    index a31c636b..6b8c116d 100644
    --- a/lib/ukmmap/exportsyms.uk
    +++ b/lib/ukmmap/exportsyms.uk
    @@ -1,2 +1,3 @@
     mmap
     munmap
    +mremap
    diff --git a/lib/ukmmap/mmap.c b/lib/ukmmap/mmap.c
    index 4e24f379..52c49e24 100644
    --- a/lib/ukmmap/mmap.c
    +++ b/lib/ukmmap/mmap.c
    @@ -164,3 +164,9 @@ int munmap(void *addr, size_t len)
        /* unimplemented munmap */
        return 0;
     }
    +
    +void *mremap(void *old_address, size_t old_size, size_t new_size,
    +           int flags, ...)
    +{
    +   return -1;
    +}
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel