Re: [Minios-devel] [UNIKRAFT PATCH 1/3] lib/posix-crypt: Introduce library skeleton

[Roxana Nicolescu <nicolescu.roxana1996@xxxxxxxxx>]

Hi Costin,


Thanks for the patch!

Reviewed-by: Roxana Nicolescu <nicolescu.roxana1996@xxxxxxxxx>


Best,

Roxana

On 26.11.2019 00:37, Costin Lupu wrote:
> posix-crypt internal library is the equivalent of the POSIX crypt library. We
> need it in order to provide crypt() and crypt_r() functions. The code will be
> imported and adapted from musl.
>
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> ---
>   lib/Makefile.uk             | 1 +
>   lib/posix-crypt/Config.uk   | 3 +++
>   lib/posix-crypt/Makefile.uk | 1 +
>   3 files changed, 5 insertions(+)
>   create mode 100644 lib/posix-crypt/Config.uk
>   create mode 100644 lib/posix-crypt/Makefile.uk
>
> diff --git a/lib/Makefile.uk b/lib/Makefile.uk
> index 4b9568a1..e2e43e44 100644
> --- a/lib/Makefile.uk
> +++ b/lib/Makefile.uk
> @@ -34,3 +34,4 @@ $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/uktime))
>   $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/ukmmap))
>   $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/ukblkdev))
>   $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/posix-process))
> +$(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/posix-crypt))
> diff --git a/lib/posix-crypt/Config.uk b/lib/posix-crypt/Config.uk
> new file mode 100644
> index 00000000..5f246377
> --- /dev/null
> +++ b/lib/posix-crypt/Config.uk
> @@ -0,0 +1,3 @@
> +config LIBPOSIX_CRYPT
> +       bool "crypt: POSIX crypt library"
> +       default n
> diff --git a/lib/posix-crypt/Makefile.uk b/lib/posix-crypt/Makefile.uk
> new file mode 100644
> index 00000000..3ac8b855
> --- /dev/null
> +++ b/lib/posix-crypt/Makefile.uk
> @@ -0,0 +1 @@
> +$(eval $(call addlib_s,libposix_crypt,$(CONFIG_LIBPOSIX_CRYPT)))
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel