Re: [Minios-devel] [UNIKRAFT PATCH 4/6] lib/uktime: Introduce POSIX timer stubs

[Costin Lupu <costin.lupu@xxxxxxxxx>]

On 12/9/19 11:28 AM, Simon Kuenzer wrote:
> On 06.12.19 14:41, Costin Lupu wrote:
>> We simply introduce the stubs for these functions. They will have to be
>> implemented later, therefore we do not add any license for now.
>>
>> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
>> ---
>>   lib/uktime/Makefile.uk |  3 +++
>>   lib/uktime/timer.c     | 39 +++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 42 insertions(+)
>>   create mode 100644 lib/uktime/timer.c
>>
>> diff --git a/lib/uktime/Makefile.uk b/lib/uktime/Makefile.uk
>> index 47fbb4b3..7a039738 100644
>> --- a/lib/uktime/Makefile.uk
>> +++ b/lib/uktime/Makefile.uk
>> @@ -5,9 +5,12 @@ LIBUKTIME_COMMON_INCLUDES-y      +=
>> -I$(LIBUKTIME_BASE)/musl-imported/include
>>   CINCLUDES-$(CONFIG_LIBUKTIME)    += $(LIBUKTIME_COMMON_INCLUDES-y)
>>   CXXINCLUDES-$(CONFIG_LIBUKTIME)  += $(LIBUKTIME_COMMON_INCLUDES-y)
>>   +LIBUKTIME_CFLAGS-y += -Wno-unused-parameter
>> +
> 
> We should not switch of compiler warnings to the core repository if
> avoidable. Could you use the `__unused` attribute macro from
> essentials.h for your stubs instead?

Ack.

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel