Re: [Minios-devel] [UNIKRAFT PATCH v3 0/3] lib/uksp: Introduce uksp library

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Hey Vlad,

thanks a lot for your work! I have a few suggestions to make this 
library even more independent and as an extra feature. Let me know what 
you think. My hope is that alternative stack protection libraries could 
be added without changes afterwards.
I commented my idea in your patches.

Thanks,

Simon

On 04.12.19 16:14, Vlad-Andrei BĂDOIU (78692) wrote:
> Currently, we provide a basic implementation of stack smashing protection that
> has a global value for all threads. The value is randomly initialized during the
> boot. Finally, this option might help us detect bugs caused by stack overflows.
>
> Changes since v1:
> * We now use a choice based config option for the stack protector level. Since
> the last version we added the regulat and strong stack protector options.
>
> Changes since v2:
> * Renamed the library to uksp
>
> Vlad-Andrei BĂDOIU (78692) (3):
>    lib/uksp: Introduce uksp library
>    build: Add option to toggle the stack protection
>    lib/ukboot: Initialize the canary value at boot
>
>   Config.uk                              | 30 ++++++++++++++
>   Makefile.uk                            | 13 +++++-
>   lib/Makefile.uk                        |  1 +
>   lib/ukboot/boot.c                      |  7 ++++
>   lib/uksp/Config.uk                     |  4 ++
>   lib/uksp/Makefile.uk                   |  5 +++
>   lib/uksp/exportsyms.uk                 |  2 +
>   lib/uksp/include/uksp/stackprotector.h | 56 ++++++++++++++++++++++++++
>   lib/uksp/ssp.c                         | 43 ++++++++++++++++++++
>   9 files changed, 159 insertions(+), 2 deletions(-)
>   create mode 100644 lib/uksp/Config.uk
>   create mode 100644 lib/uksp/Makefile.uk
>   create mode 100644 lib/uksp/exportsyms.uk
>   create mode 100644 lib/uksp/include/uksp/stackprotector.h
>   create mode 100644 lib/uksp/ssp.c
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel