Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH 1/1] sincosl.c: Import from musl

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Vlad,

You're missing a #include <math.h> in sincosl.c, but I can add that on upstream.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 08.01.20, 15:17, "Vlad-Andrei BĂDOIU (78692)" 
<vlad_andrei.badoiu@xxxxxxxxxxxxxxx> wrote:

    Copied as is from the official musl git mirror
    git://git.musl-libc.org/musl, commit 6fcb440d.
    
    We only keep the non optimized definition since
    all the long double math functions from newlib
    are wrappers over double.
    
    Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
    ---
     Makefile.uk                      |  1 +
     musl-imported/src/math/sincosl.c | 10 ++++++++++
     2 files changed, 11 insertions(+)
     create mode 100644 musl-imported/src/math/sincosl.c
    
    diff --git a/Makefile.uk b/Makefile.uk
    index 17d8d7a..a963e82 100644
    --- a/Makefile.uk
    +++ b/Makefile.uk
    @@ -132,6 +132,7 @@ LIBNEWLIBGLUE_SRCS-y += $(LIBNEWLIBC_BASE)/mntent.c
     LIBNEWLIBGLUE_SRCS-y += $(LIBNEWLIBC_BASE)/musl-imported/src/misc/syslog.c
     LIBNEWLIBGLUE_SRCS-y += 
$(LIBNEWLIBC_BASE)/musl-imported/src/termios/tcsetattr.c
     LIBNEWLIBGLUE_SRCS-y += 
$(LIBNEWLIBC_BASE)/musl-imported/src/termios/tcgetattr.c
    +LIBNEWLIBGLUE_SRCS-y += $(LIBNEWLIBC_BASE)/musl-imported/src/math/sincosl.c
     
     ifeq ($(CONFIG_LIBNEWLIBC_CRYPT),y)
     LIBNEWLIBGLUE_CFLAGS-y   += -Wno-missing-braces -Wno-sign-compare 
-Wno-char-subscripts
    diff --git a/musl-imported/src/math/sincosl.c 
b/musl-imported/src/math/sincosl.c
    new file mode 100644
    index 0000000..003f6e4
    --- /dev/null
    +++ b/musl-imported/src/math/sincosl.c
    @@ -0,0 +1,10 @@
    +#define _GNU_SOURCE
    +
    +void sincosl(long double x, long double *sin, long double *cos)
    +{
    +   double sind, cosd;
    +
    +   sincos(x, &sind, &cosd);
    +   *sin = sind;
    +   *cos = cosd;
    +}
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel