Re: [Minios-devel] [UNIKRAFT PATCH 2/4] lib/vfscore: Register `read`, `readv` to syscall_shim

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

On 08.01.20 14:58, Gaulthier Gain wrote:
> Hi Simon,
>
> Thanks for this patch series.
>
> Please, see my comment inline:
>
> > On 12 Dec 2019, at 13:26, Simon Kuenzer <simon.kuenzer@xxxxxxxxx> wrote:
> >
> > Registers `read` and `readv` system calls to syscall_shim library.
> >
> > Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> > ---
> > lib/vfscore/Makefile.uk   | 1 +
> > lib/vfscore/exportsyms.uk | 4 ++++
> > lib/vfscore/main.c        | 5 +++--
> > 3 files changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/vfscore/Makefile.uk b/lib/vfscore/Makefile.uk
> > index 2022e949..44b2e6a8 100644
> > --- a/lib/vfscore/Makefile.uk
> > +++ b/lib/vfscore/Makefile.uk
> > @@ -26,3 +26,4 @@ LIBVFSCORE_SRCS-$(CONFIG_LIBVFSCORE_AUTOMOUNT_ROOTFS) += \
> >
> >
> > UK_PROVIDED_SYSCALLS-$(CONFIG_LIBVFSCORE) += write-3 writev-3
> > +UK_PROVIDED_SYSCALLS-$(CONFIG_LIBVFSCORE) += read-3 readv-3
> > diff --git a/lib/vfscore/exportsyms.uk b/lib/vfscore/exportsyms.uk
> > index 690801b6..4ad4ee38 100644
> > --- a/lib/vfscore/exportsyms.uk
> > +++ b/lib/vfscore/exportsyms.uk
> > @@ -19,6 +19,8 @@ uk_syscall_e_write
> > uk_syscall_r_write
> > close
> > read
> > +uk_syscall_e_read
> > +uk_syscall_r_read
> > mkdir
> > fsync
> > fstat
> > @@ -57,6 +59,8 @@ pread
> > pwrite
> > pwritev
> > readv
> > +uk_syscall_e_readv
> > +uk_syscall_r_readv
> > writev
> > truncate
> > mknod
> > diff --git a/lib/vfscore/main.c b/lib/vfscore/main.c
> > index b0d8335a..383c6644 100644
> > --- a/lib/vfscore/main.c
> > +++ b/lib/vfscore/main.c
> > @@ -338,7 +338,7 @@ ssize_t pread(int fd, void *buf, size_t count, off_t offset)
> >
> > LFS64(pread);
> >
> > -ssize_t read(int fd, void *buf, size_t count)
> > +UK_SYSCALL_DEFINE(ssize_t, read, int fd, void *, buf, size_t, count)
> A comma is missing between 'int' and 'fd'. Without it, we got errors.
Ouch, yes, it is missing. Sorry for this. I will fix it with a v2.
Thanks for your review.

Simon

> > {
> >         return pread(fd, buf, count, -1);
> > }
> > @@ -408,7 +408,8 @@ ssize_t preadv(int fd, const struct iovec *iov, int iovcnt, 
> > off_t offset)
> >
> > LFS64(preadv);
> >
> > -ssize_t readv(int fd, const struct iovec *iov, int iovcnt)
> > +UK_SYSCALL_DEFINE(ssize_t, readv,
> > +                 int, fd, const struct iovec *, iov, int, iovcnt)
> > {
> >         return preadv(fd, iov, iovcnt, -1);
> > }
> > --
> > 2.20.1
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel