[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT/MUSL PATCH V2 03/28] Review formatting for files generations in Makefile.uk



Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 29.01.20 22:18, Gaulthier Gain wrote:
Signed-off-by: Gaulthier Gain <gaulthier.gain@xxxxxxxxx>
---
  Makefile.uk | 27 +++++++++++++--------------
  1 file changed, 13 insertions(+), 14 deletions(-)

diff --git a/Makefile.uk b/Makefile.uk
index 8838db0..69847fc 100644
--- a/Makefile.uk
+++ b/Makefile.uk
@@ -67,27 +67,26 @@ CXXINCLUDES-y  += $(LIBMUSL_GLOBAL_INCLUDES-y)
  
################################################################################
  # Musl-specific Targets
  
################################################################################
-# generate alltypes.h through musl sed script                  
+# generate alltypes.h through musl sed script
  $(LIBMUSL)/arch/$(ARCH)/bits/alltypes.h: $(LIBMUSL_BUILD)/.patched
-                             $(call verbose_cmd,CONFIGURE,libmusl: $(notdir 
$@),\
-                             sed -f $(LIBMUSL)/tools/mkalltypes.sed \
-                             $(LIBMUSL)/arch/$(ARCH)/bits/alltypes.h.in \
-                             $(LIBMUSL)/include/alltypes.h.in > $@ && \
-                             $(TOUCH) $@)
+       $(call verbose_cmd,CONFIGURE,libmusl: $(notdir $@),\
+               sed -f $(LIBMUSL)/tools/mkalltypes.sed \
+               $(LIBMUSL)/arch/$(ARCH)/bits/alltypes.h.in \
+               $(LIBMUSL)/include/alltypes.h.in > $@ && \
+               $(TOUCH) $@)
# generate syscall.h
  $(LIBMUSL)/arch/$(ARCH)/bits/syscall.h: 
$(LIBMUSL)/arch/$(ARCH)/bits/syscall.h.in
-                             $(call verbose_cmd,CONFIGURE,libmusl: $@,\
-                             cp $< $@ && \
-                             sed -n -e s/__NR_/SYS_/p < $< >> $@ && \
-                             $(TOUCH) $@)
+       $(call verbose_cmd,CONFIGURE,libmusl: $(notdir $@),\
+               cp $< $@ && \
+               sed -n -e s/__NR_/SYS_/p < $< >> $@ && \
+               $(TOUCH) $@)
# generate version.h
  $(LIBMUSL)/src/internal/version.h:
-                             $(call verbose_cmd,CONFIGURE,libmusl: $@,\
-                             printf '#define VERSION "%s"\n' "$$(cd $(LIBMUSL); sh 
tools/version.sh)" > $@ \
-                             $(TOUCH) $@)
-
+       $(call verbose_cmd,CONFIGURE,libmusl: $(notdir $@),\
+               printf '#define VERSION "%s"\n' "$$(cd $(LIBMUSL); sh 
tools/version.sh)" > $@ \
+               $(TOUCH) $@)
UK_PREPARE += $(LIBMUSL)/arch/$(ARCH)/bits/alltypes.h
  UK_PREPARE += $(LIBMUSL)/arch/$(ARCH)/bits/syscall.h


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.