Re: [Minios-devel] [UNIKRAFT PATCH v6 5/5] lib/ukalloc: implement new allocator helpers

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

On 30.01.20 11:07, Hugo Lefeuvre wrote:
> On Wed, 2020-01-29 at 11:39 +0100, Simon Kuenzer wrote:
> >   <snip>
> > Hum, I am wondering if we should introduce `uk_alloc_init_malloc` as
> > an
> > helper that initializes the struct for allocators that just don't
> > support palloc() and pfree(). Another wrapper based on this could
> > add
> > the additonal callbacks for posix_memalign, memalign, and maybe
> > calloc,
> > like:
> >
> > #define uk_alloc_init_simple(a, malloc_f, free_f, addmem_f) \
> >         uk_alloc_init_malloc(.<arguments here>.)
> >
> > What do you think?
> Agree. I have updated it in the v7. I didn't add
> any uk_alloc_init_simple though, I think this can be added in
> subsequent patches.
>
> regards,
> Hugo
This is totally fine. Thanks a lot for the v7!

Thanks,

Simon

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel