Re: [Minios-devel] [UNIKRAFT PATCH] build: Add -no-pie flag to Go units

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Simon, looks good, thanks.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 07.02.20, 13:10, "Simon Kuenzer" <simon.kuenzer@xxxxxxxxx> wrote:

    Unlike other source files (Assembly, C, C++), the -no-pie argument was
    not handed over to Go compilation units. Because of consistency
    reasons we are handing this argument now also to the GCC Go compiler.
    
    Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
    ---
     Makefile.uk | 1 +
     1 file changed, 1 insertion(+)
    
    diff --git a/Makefile.uk b/Makefile.uk
    index 67c372e5..3f01a251 100644
    --- a/Makefile.uk
    +++ b/Makefile.uk
    @@ -76,5 +76,6 @@ M4FLAGS  += -DUK_VERSION=$(UK_VERSION).$(UK_SUBVERSION)
     ASFLAGS-$(call gcc_version_ge,6,1) += -no-pie
     CFLAGS-$(call gcc_version_ge,6,1)  += -no-pie
     CXXFLAGS-$(call gcc_version_ge,6,1)        += -no-pie
    +GOFLAGS-$(call gcc_version_ge,6,1) += -no-pie
     LIBLDFLAGS-$(call gcc_version_ge,6,1)      += -no-pie
     LDFLAGS-$(call gcc_version_ge,6,1) += -no-pie
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel