[Minios-devel] [UNIKRAFT PATCH 1/4] build: Hide warning about `exportsyms.uk`

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Shows the warning about missing `exportsyms.uk` only when verbose
mode (make V=1) is enabled.

Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
---
 Makefile                     | 47 +++++++++++++++++++++---------------
 support/build/Makefile.rules |  2 +-
 2 files changed, 29 insertions(+), 20 deletions(-)

diff --git a/Makefile b/Makefile
index 84adb16d..eecb3dfa 100644
--- a/Makefile
+++ b/Makefile
@@ -64,6 +64,34 @@ space := $(empty) $(empty)
 # explictly throw away any output from 'cd' here.
 export CDPATH :=
 
+# To put more focus on warnings, be less verbose as default
+# Use 'make V=1' to see the full commands
+ifeq ("$(origin V)", "command line")
+  BUILD_VERBOSE = $(V)
+endif
+ifndef BUILD_VERBOSE
+  BUILD_VERBOSE = 0
+endif
+
+ifeq ($(KBUILD_VERBOSE),1)
+  Q =
+ifndef VERBOSE
+  VERBOSE = 1
+endif
+export VERBOSE
+else
+   Q = @
+endif
+
+# Helper that shows an `info` message only
+# when verbose mode is on
+# verbose_info $verbosemessage
+ifeq ($(BUILD_VERBOSE),1)
+verbose_info = $(info $(1))
+else
+verbose_info =
+endif
+
 # Use current directory as base
 CONFIG_UK_BASE ?= $(CURDIR)
 override CONFIG_UK_BASE := $(realpath $(CONFIG_UK_BASE))
@@ -190,25 +218,6 @@ noconfig_targets   := ukconfig menuconfig nconfig gconfig 
xconfig config \
                           scriptconfig iscriptconfig kmenuconfig guiconfig \
                           dumpvarsconfig $(null_targets)
 
-# To put more focus on warnings, be less verbose as default
-# Use 'make V=1' to see the full commands
-ifeq ("$(origin V)", "command line")
-  BUILD_VERBOSE = $(V)
-endif
-ifndef BUILD_VERBOSE
-  BUILD_VERBOSE = 0
-endif
-
-ifeq ($(KBUILD_VERBOSE),1)
-  Q =
-ifndef VERBOSE
-  VERBOSE = 1
-endif
-export VERBOSE
-else
-   Q = @
-endif
-
 # we want bash as shell
 SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \
         else if [ -x /bin/bash ]; then echo /bin/bash; \
diff --git a/support/build/Makefile.rules b/support/build/Makefile.rules
index 228446b6..e817ddcb 100644
--- a/support/build/Makefile.rules
+++ b/support/build/Makefile.rules
@@ -659,7 +659,7 @@ endef
 # buildrule_olib $libname
 define buildrule_olib =
 $(if $(wildcard $($(call vprefix_lib,$(1),EXPORTS))),,\
-       $(warning Warning: Definition of exported symbols for $(1) missing: 
$($(call vprefix_lib,$(1),EXPORTS))) \
+       $(call verbose_info,Warning: Definition of exported symbols for $(1) 
missing: $($(call vprefix_lib,$(1),EXPORTS))) \
 )
 
 $(call libname2preolib,$(1)): $($(call vprefix_lib,$(1),OBJS)) \
-- 
2.20.1


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel