Re: [Minios-devel] [UNIKRAFT PATCH 3/4] build: Use $(HOSTLN) instead of `ln`

["felipehuici ." <felipehuici@xxxxxxxxx>]

Hi Simon, looks good, thanks.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On Thu, Feb 13, 2020 at 12:42 AM Simon Kuenzer <simon.kuenzer@xxxxxxxxx> wrote:
>
> Uses $(HOSTLN) command definition instead of `ln` directly. This
> affects and updates the rules of linking the following files to the
> `build/` directory: uk-gdb.py, Makefile
>
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 79483481..f0b6048c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -613,7 +613,7 @@ images: $(UK_DEBUG_IMAGES) $(UK_DEBUG_IMAGES-y) 
> $(UK_IMAGES) $(UK_IMAGES-y)
>
>  GDB_HELPER_LINKS := $(addsuffix .gdb.py,$(UK_DEBUG_IMAGES) 
> $(UK_DEBUG_IMAGES-y))
>  $(GDB_HELPER_LINKS):
> -       $(call verbose_cmd,LN,$(notdir $@), ln -sf uk-gdb.py $@)
> +       $(call verbose_cmd,LN,$(notdir $@),$(HOSTLN) -sf uk-gdb.py $@)
>
>  SCRIPTS_DIR_BACKSLASHED = $(subst /,\/,$(SCRIPTS_DIR))
>  $(BUILD_DIR)/uk-gdb.py: $(SCRIPTS_DIR)/uk-gdb.py
> @@ -899,7 +899,7 @@ else #!($(sub_make_exec),)
>  export sub_make_exec:=1
>
>  $(BUILD_DIR)/Makefile:
> -       ln -sn $(CONFIG_UK_BASE)/Makefile $(@)
> +       $(call verbose_cmd,LN,$(notdir $@),$(HOSTLN) -sf 
> $(CONFIG_UK_BASE)/Makefile $@)
>
>  $(filter-out _all $(BUILD_DIR)/Makefile sub-make distclean properclean help 
> $(lastword $(MAKEFILE_LIST)), \
>    $(MAKECMDGOALS)) all: sub-make
> --
> 2.20.1
>
>
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel